chore(ci): add lefthook hooks and fix pre-existing fmt drift

CI runs cargo fmt --check and cargo clippy -D warnings, but no local hook
mirrored that — formatting drift slipped in via earlier merges and only
surfaced once CI ran. Add a lefthook.yml so contributors get the same
checks pre-commit (fmt) / pre-push (clippy), and fix the existing fmt
violations in observer.rs and the e2e test harness.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: eliebleton-manomano

CONTRIBUTING.md

@@ -1,3 +1,12 @@
 # Contributing
 
 See [Contributing to this repository](https://github.com/ManoManoTech/ALaMano/blob/master/CONTRIBUTING.md).
+
+## Git hooks
+
+This repo ships a [lefthook](https://github.com/evilmartians/lefthook) config (`lefthook.yml`) that mirrors CI:
+
+- `pre-commit`: `cargo fmt --check`
+- `pre-push`: `cargo clippy --all-targets -- -D warnings`
+
+Install lefthook once (`brew install lefthook` / `go install github.com/evilmartians/lefthook@latest`) then run `lefthook install` in the repo to wire up `.git/hooks/`.

lefthook.yml

@@ -0,0 +1,18 @@
+# Lefthook git hooks. Install once with: lefthook install
+# https://github.com/evilmartians/lefthook
+#
+# Mirrors what CI enforces (.github/workflows/ci.yml):
+#   - cargo fmt --check       → pre-commit (fast, runs on every commit)
+#   - cargo clippy -D warnings → pre-push   (slower, runs once before push)
+
+pre-commit:
+  parallel: true
+  commands:
+    fmt:
+      glob: "*.rs"
+      run: cargo fmt --check
+
+pre-push:
+  commands:
+    clippy:
+      run: cargo clippy --all-targets -- -D warnings

src/pipeline/observer.rs

@@ -263,8 +263,7 @@ mod tests {
 
     #[test]
     fn pipeline_observer_avg_upload_ms_computed_from_atomics() {
-        let (_lt, _lr, _bt, _br, batches, upload_us, _c, obs) =
-            make_pipeline_observer(4, 4, None);
+        let (_lt, _lr, _bt, _br, batches, upload_us, _c, obs) = make_pipeline_observer(4, 4, None);
         batches.store(4, Ordering::Relaxed);
         upload_us.store(20_000, Ordering::Relaxed); // 20_000 us total = 20 ms total => 5 ms avg
         assert!((obs.avg_upload_ms() - 5.0).abs() < 1e-9);

tests/e2e/garage.rs

@@ -94,9 +94,7 @@ pub async fn start_garage(bucket_name: &str) -> Result<GarageHandle> {
     let image = GenericImage::new(GARAGE_IMAGE, GARAGE_TAG)
         .with_exposed_port(ContainerPort::Tcp(S3_PORT))
         .with_exposed_port(ContainerPort::Tcp(ADMIN_PORT))
-        .with_wait_for(WaitFor::message_on_stderr(
-            "S3 API server listening on",
-        ));
+        .with_wait_for(WaitFor::message_on_stderr("S3 API server listening on"));
 
     let container = image
         .with_mount(Mount::bind_mount(
@@ -196,10 +194,7 @@ fn parse_key_create(stdout: &str) -> Option<(String, String)> {
     Some((access?, secret?))
 }
 
-async fn exec_capture(
-    container: &ContainerAsync<GenericImage>,
-    cmd: &[&str],
-) -> Result<String> {
+async fn exec_capture(container: &ContainerAsync<GenericImage>, cmd: &[&str]) -> Result<String> {
     let mut result = container
         .exec(ExecCommand::new(cmd.iter().map(|s| s.to_string())))
         .await

tests/e2e/nginx.rs

@@ -70,9 +70,7 @@ impl NginxHandle {
             .exec(ExecCommand::new([
                 "sh".to_string(),
                 "-c".to_string(),
-                format!(
-                    "chmod -R a+rX /var/dumps && chown -R {host_uid}:{host_uid} /var/dumps",
-                ),
+                format!("chmod -R a+rX /var/dumps && chown -R {host_uid}:{host_uid} /var/dumps",),
             ]))
             .await
             .context("chmod/chown /var/dumps in container")?;
@@ -90,9 +88,7 @@ impl NginxHandle {
         let mut out = Vec::new();
         for e in entries {
             let p = e.path();
-            out.push(
-                std::fs::read(&p).with_context(|| format!("reading dump {}", p.display()))?,
-            );
+            out.push(std::fs::read(&p).with_context(|| format!("reading dump {}", p.display()))?);
         }
         Ok(out)
     }