Skip to content

Commit a078cce

Browse files
AIP-84 Fix version_number in grid endpoint (apache#46323)
1 parent 53963c6 commit a078cce

File tree

5 files changed

+11
-11
lines changed

5 files changed

+11
-11
lines changed

airflow/api_fastapi/core_api/datamodels/ui/grid.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
from __future__ import annotations
1919

2020
from datetime import datetime
21-
from uuid import UUID
2221

2322
from pydantic import BaseModel, Field
2423

@@ -51,7 +50,7 @@ class GridDAGRunwithTIs(BaseModel):
5150
run_type: DagRunType
5251
data_interval_start: datetime | None
5352
data_interval_end: datetime | None
54-
version_number: UUID | None
53+
version_number: int | None
5554
note: str | None
5655
task_instances: list[GridTaskInstanceSummary]
5756

airflow/api_fastapi/core_api/openapi/v1-generated.yaml

+1-2
Original file line numberDiff line numberDiff line change
@@ -8786,8 +8786,7 @@ components:
87868786
title: Data Interval End
87878787
version_number:
87888788
anyOf:
8789-
- type: string
8790-
format: uuid
8789+
- type: integer
87918790
- type: 'null'
87928791
title: Version Number
87938792
note:

airflow/api_fastapi/core_api/routes/ui/grid.py

+7-4
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323

2424
from fastapi import Depends, HTTPException, Request, status
2525
from sqlalchemy import select
26+
from sqlalchemy.orm import joinedload
2627

2728
from airflow import DAG
2829
from airflow.api_fastapi.common.db.common import SessionDep, paginated_select
@@ -93,7 +94,9 @@ def grid_data(
9394
base_query = (
9495
select(DagRun)
9596
.join(DagRun.dag_run_note, isouter=True)
97+
.join(DagRun.dag_version, isouter=True)
9698
.select_from(DagRun)
99+
.options(joinedload(DagRun.dag_version))
97100
.where(DagRun.dag_id == dag.dag_id)
98101
)
99102

@@ -212,11 +215,11 @@ def grid_data(
212215
run_type=dag_run.run_type,
213216
data_interval_start=dag_run.data_interval_start,
214217
data_interval_end=dag_run.data_interval_end,
215-
version_number=dag_run.dag_version_id,
218+
version_number=dag_run.dag_version.version_number if dag_run.dag_version else None,
216219
note=dag_run.note,
217-
task_instances=task_instance_summaries[dag_run.run_id]
218-
if dag_run.run_id in task_instance_summaries
219-
else [],
220+
task_instances=(
221+
task_instance_summaries[dag_run.run_id] if dag_run.run_id in task_instance_summaries else []
222+
),
220223
)
221224
for dag_run in dag_runs
222225
]

airflow/ui/openapi-gen/requests/schemas.gen.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -3401,8 +3401,7 @@ export const $GridDAGRunwithTIs = {
34013401
version_number: {
34023402
anyOf: [
34033403
{
3404-
type: "string",
3405-
format: "uuid",
3404+
type: "integer",
34063405
},
34073406
{
34083407
type: "null",

airflow/ui/openapi-gen/requests/types.gen.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -889,7 +889,7 @@ export type GridDAGRunwithTIs = {
889889
run_type: DagRunType;
890890
data_interval_start: string | null;
891891
data_interval_end: string | null;
892-
version_number: string | null;
892+
version_number: number | null;
893893
note: string | null;
894894
task_instances: Array<GridTaskInstanceSummary>;
895895
};

0 commit comments

Comments
 (0)