Added todos for other constraint types

Author: Kwesi Rutledge

symbolic/matrix_constraint.go

@@ -259,9 +259,17 @@ func (mc MatrixConstraint) ImpliesThisIsAlsoSatisfied(other Constraint) bool {
 				}
 			}
 		}
+	case VectorConstraint:
+		// TODO: Implement more advanced implication checks.
+		return false
+	case MatrixConstraint:
+		// TODO: Implement more advanced implication checks.
+		return false
 	default:
 		// Other types of constraints are not currently supported.
-		return false
+		panic(
+			fmt.Errorf("implication checking between MatrixConstraint and %T is not currently supported", other),
+		)
 	}
 
 	// If no avenues for implication were found, return false.

symbolic/scalar_constraint.go

@@ -433,6 +433,12 @@ func (sc ScalarConstraint) ImpliesThisIsAlsoSatisfied(other Constraint) bool {
 				panic("unreachable code reached in ScalarConstraint.ImpliesThisIsAlsoSatisfied")
 			}
 		}
+	case VectorConstraint:
+		// TODO: Implement more advanced implication checks.
+		return false
+	case MatrixConstraint:
+		// TODO: Implement more advanced implication checks.
+		return false
 	default:
 		// Other types of constraints are not currently supported.
 		panic(

symbolic/vector_constraint.go

@@ -390,6 +390,12 @@ func (vc VectorConstraint) ImpliesThisIsAlsoSatisfied(other Constraint) bool {
 				return true
 			}
 		}
+	case VectorConstraint:
+		// TODO: Implement more advanced implication checks.
+		return false
+	case MatrixConstraint:
+		// TODO: Implement more advanced implication checks.
+		return false
 	default:
 		// Other types of constraints are not currently supported.
 		panic(

testing/symbolic/vector_constraint_test.go

@@ -1342,20 +1342,10 @@ func TestVectorConstraint_ImpliesThisIsAlsoSatisfied3(t *testing.T) {
 	}
 
 	// Test
-	defer func() {
-		r := recover()
-		if r == nil {
-			t.Errorf(
-				"Expected vc.ImpliesThisIsAlsoSatisfied() to panic; received \"%v\"",
-				r,
-			)
-		}
-	}()
-
-	result := vc.ImpliesThisIsAlsoSatisfied(vc2)
+	result := vc.ImpliesThisIsAlsoSatisfied(vc2) // TODO: Fix this test to return true
 	if result {
 		t.Errorf(
-			"Expected vc.ImpliesThisIsAlsoSatisfied() to return false; received true",
+			"Expected vc.ImpliesThisIsAlsoSatisfied() to return true; received false",
 		)
 	}
 }