-
Notifications
You must be signed in to change notification settings - Fork 0
Approval-Gated CI setup for self managed repo #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-hunt-materialize
previously approved these changes
Nov 3, 2025
alex-hunt-materialize
previously approved these changes
Nov 5, 2025
bobbyiliev
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds approval-gated testing for AWS/GCP/Azure infrastructure to prevent accidental resource provisioning and manage costs.
Key Features
.tf/.gofiles, ignores README/docstest/utils/,kubernetes/modules/) run all cloudsNew Workflows
test-aws.yml,test-gcp.yml,test-azure.ymlCI infra setup
.github/setup/- Complete Terraform configuration for AWS/GCP/Azure infra/oidc rbac setup.NOTE
1. the oidc setup for all the cloud providers exists in terraform files under .github/setup/ I am using s3 backend for tfstate. if you make some changes to the setup you should add the aws profile of the mz-scratch aws account.
2. AWS and Azure don’t follow principle of least privilege and the OIDC service principal has borader access for now. For azure it was mostly because I lacked permissions myself. So i will fix that in future CI enhancements.
Behavior