Skip to content

Commit d4ce46f

Browse files
authored
Increase SQL Server healthcheck start time (#33646)
Increase the healthcheck start period for SQL Server to 1 minute ### Motivation unblock test MaterializeInc/database-issues#9624 ### Checklist - [ ] This PR has adequate test coverage / QA involvement has been duly considered. ([trigger-ci for additional test/nightly runs](https://trigger-ci.dev.materialize.com/)) - [ ] This PR has an associated up-to-date [design doc](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/design/README.md), is a design doc ([template](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/design/00000000_template.md)), or is sufficiently small to not require a design. <!-- Reference the design in the description. --> - [ ] If this PR evolves [an existing `$T ⇔ Proto$T` mapping](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/command-and-response-binary-encoding.md) (possibly in a backwards-incompatible way), then it is tagged with a `T-proto` label. - [ ] If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label ([example](MaterializeInc/cloud#5021)). <!-- Ask in #team-cloud on Slack if you need help preparing the cloud PR. --> - [ ] If this PR includes major [user-facing behavior changes](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/guide-changes.md#what-changes-require-a-release-note), I have pinged the relevant PM to schedule a changelog post.
1 parent 9f6b7ac commit d4ce46f

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

misc/python/materialize/mzcompose/services/sql_server.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ def __init__(
4242
"healthcheck": {
4343
"test": f"/opt/mssql-tools18/bin/sqlcmd -C -S localhost -U sa -P '{sa_password}' -Q 'SELECT 1'",
4444
"interval": "1s",
45-
"start_period": "30s",
45+
"start_period": "60s",
4646
},
4747
},
4848
)

misc/python/materialize/zippy/scenarios.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
CreateSqlServerTable,
3838
SqlServerDML,
3939
SqlServerStart,
40+
SqlServerRestart,
4041
)
4142
from materialize.zippy.sql_server_cdc_actions import CreateSqlServerCdcTable
4243
from materialize.zippy.mz_actions import (
@@ -252,8 +253,7 @@ def actions_with_weight(self) -> dict[ActionOrFactory, float]:
252253
KillClusterd: 5,
253254
StoragedKill: 5,
254255
StoragedStart: 5,
255-
# TODO: Reenable when database-issues#9624 is fixed
256-
# SqlServerRestart: 10,
256+
SqlServerRestart: 10,
257257
CreateViewParameterized(): 10,
258258
ValidateView: 20,
259259
SqlServerDML: 100,

0 commit comments

Comments
 (0)