Skip to content

Remove feature flag for #30974 #32031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

frankmcsherry
Copy link
Contributor

Remove the defensive feature flag for #30974, which seems to have landed without incident.

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@frankmcsherry frankmcsherry requested a review from ggevay March 27, 2025 17:16
@frankmcsherry frankmcsherry requested review from a team as code owners March 27, 2025 17:16
@frankmcsherry frankmcsherry requested a review from aljoscha March 27, 2025 17:16
@ggevay
Copy link
Contributor

ggevay commented Mar 27, 2025

This will be rolled out next week. (The PR was merged on Friday, and we do the release cut on Thursday evening/night.)

Copy link
Contributor

@ggevay ggevay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature has been rolled out yesterday, so this PR can go in now.

@frankmcsherry frankmcsherry merged commit 2b99ef8 into MaterializeInc:main Apr 4, 2025
83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants