Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Operators on EdgeWeight #21

Open
Mathemalsky opened this issue Feb 7, 2023 · 2 comments
Open

Review Operators on EdgeWeight #21

Mathemalsky opened this issue Feb 7, 2023 · 2 comments
Labels
check needs closer look if current implementation is really correct

Comments

@Mathemalsky
Copy link
Owner

Mathemalsky commented Feb 7, 2023 •
edited
Loading

Especially the operator+ needs a review in context of sparse matrices it could lead to absorption of everything.

affected functions:

  • AdjMatGraph::square()
  • AdjacencyMatrixGraph<Directionality::Directed>::undirected()
@Mathemalsky Mathemalsky added the check needs closer look if current implementation is really correct label Feb 7, 2023
@Mathemalsky
Copy link
Owner Author

Everything is correct in theory, but implicit entries in sparse matrix must be treated as infinity. AdjacencyMatrixGraph<Directionality::Directed>::undirected() does no longer exist

@Mathemalsky
Copy link
Owner Author

affects AdjMatGraph::adjacent()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
check needs closer look if current implementation is really correct
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Mathemalsky