Different format of message id on SubmitSm response and on DeliveryReceipt

[isouza-daitan]

While testing delivery receipts I have noticed that the SubmitSm response has a message id formatted as a '0' left-padded hexadecimal string (https://github.com/MavoCz/smscsim/blob/master/src/main/java/net/voldrich/smscsim/server/SmscSmppSessionHandler.java#L51) but the message id on the delivery receipt is formatted as a non-padded decimal (https://github.com/MavoCz/smscsim/blob/master/src/main/java/net/voldrich/smscsim/server/SmppPduUtils.java#L33).

Is that on purpose to simulate a specific implementation or is it a bug? I'm willing to submit a PR if it is indeed a bug.

[krasa]

different SMSCs use different formats, they should probably match, but who knows... If you want to simulate your SMSC, you need to check what they actually return.
They could even set DeliveryReceipt#messageId empty, and only return it as OptionalParameter

[isouza-daitan]

Sure, I changed the code on our fork to simulate our SMSC. I was just wondering if this is a bug in this project or if it is intentional.