Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No border style update when animation duration is set to 0 #9

Open
n1fi opened this issue Feb 29, 2024 · 6 comments
Open

No border style update when animation duration is set to 0 #9

n1fi opened this issue Feb 29, 2024 · 6 comments

Comments

@n1fi
Copy link

n1fi commented Feb 29, 2024

The active tiddler is correct and the shortcuts work but it does not have the border style applied.

  1. Set animation duration to 0.
  2. Click on a link in a tiddler to open another tiddler.
  3. The border style of the now active tiddler is not updated.

This does not happen when animation duration is > 0.

Thank you for creating this plugin!

@MaxGyver83
Copy link
Owner

Thank you for your report! I'll look into this.

@MaxGyver83
Copy link
Owner

When you say animation duration, you talk about INSTANT_NAVIGATION_BEFORE, right?
Just in case this is a misunderstanding: This number is not the duration of the animation. It's a threshold to decide if there is a animation at all. When you set this to 0, do you want always instant or animated jumps?

@MaxGyver83
Copy link
Owner

I can't reproduce this. Which TiddlyWiki version and which plugin version do you use?

@n1fi
Copy link
Author

n1fi commented Mar 1, 2024

When you say animation duration, you talk about INSTANT_NAVIGATION_BEFORE, right?

I'm referring to the setting in TiddlyWiki: Control panel > Info > Basics > Animation duration.

@MaxGyver83
Copy link
Owner

OK, I see. Thank you!

@MaxGyver83
Copy link
Owner

I can reproduce this. But I can't say now why this happens. Maybe a TiddlyWiki hook is skipped when the animation duration is set to 0. I need to investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants