Skip to content

Conversation

@adityasasidhar
Copy link

Hey everyone! This is my very first contribution to Memori. I've added some unit tests for the _cli.py module to make sure our command line output, like the banner and notices, always looks and behaves exactly as expected.

@devwdave
Copy link
Collaborator

Hi @adityasasidhar

Thanks for putting this together. I appreciate you taking the time to add coverage around the CLI helpers.

One concern on my end is that these tests are primarily asserting exact print() output. In practice that tends to be a bit brittle (small copy/format tweaks can break CI) and it doesn’t really exercise the failure modes we'd be concerned with in the cli; argument parsing, command wiring, exit codes, and error paths.

Would you be open to adjusting the tests toward higher signal behavior? For example, invoking the CLI/entrypoint in a more end-to-end way (args → command execution) and asserting on exit codes and a couple key outcomes, while keeping output checks looser (e.g., version is present, important keywords show up) rather than matching exact strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants