-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge feat/confloader to dev/0.0.1 #9
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Esgr0bar
added
ready for review
feature or request is ready for review
ready for merge
feature or request has been reviewed and is ready to merge
labels
May 24, 2024
improvement by using 'anyhow' instead of 'Box dyn Error' : fn load_config(file_path: &str) -> Result<MachineConfig> {
let config_str = fs::read_to_string(file_path)
.with_context(|| format!("Failed to read configuration file: {}", file_path))?;
let config: MachineConfig = match file_path.rsplit('.').next().ok_or_else(|| anyhow::anyhow!("No file extension found"))? {
"toml" => toml::from_str(&config_str)
.with_context(|| format!("Failed to parse TOML configuration file: {}", file_path))?,
_ => return Err(anyhow::anyhow!("Unsupported file format: {}", file_path)),
};
Ok(config)
} |
@Esgr0bar can you add |
theo-abel
reviewed
May 28, 2024
theo-abel
reviewed
May 28, 2024
theo-abel
reviewed
May 28, 2024
theo-abel
reviewed
May 28, 2024
theo-abel
requested changes
May 28, 2024
theo-abel
added
enhancement
New feature or request
and removed
ready for merge
feature or request has been reviewed and is ready to merge
labels
Jun 18, 2024
shard77
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - nothing to add here as of right now
theo-abel
approved these changes
Jun 19, 2024
theo-abel
added
the
ready for merge
feature or request has been reviewed and is ready to merge
label
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
ready for merge
feature or request has been reviewed and is ready to merge
ready for review
feature or request is ready for review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.