Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUX-1295] Linebreaks between log messages #13

Open
9999years opened this issue Aug 10, 2023 · 1 comment
Open

[DUX-1295] Linebreaks between log messages #13

9999years opened this issue Aug 10, 2023 · 1 comment
Labels
Low priority Created by Linear-GitHub Sync

Comments

@9999years
Copy link
Member

The ghcid-ng logging code was adapted from the bootstrap-mercury logging code, which prints one-line log messages on a single line, but places a linebreak before and after long log messages (which get wrapped onto multiple lines).

Unfortunately, this doesn't work super well with ghcid-ng, where log messages are interspersed with forwarded output from the underlying ghci session. This causes line breaks to be weird and nonsensical.

The easiest way forward is probably to just remove the linebreaks before and after long messages.

From SyncLinear.com | DUX-1295

@9999years 9999years added the Medium priority Created by Linear-GitHub Sync label Oct 5, 2023
9999years added a commit that referenced this issue Oct 16, 2023
@9999years
Copy link
Member Author

I'm going to fix this as part of making the tracing formatter its own crate (tracing-human-layer).

@9999years 9999years added Low priority Created by Linear-GitHub Sync and removed Medium priority Created by Linear-GitHub Sync labels Oct 31, 2023
@9999years 9999years added this to the 1.0 milestone Mar 1, 2024
@9999years 9999years removed this from the 1.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Low priority Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

1 participant