feat: java.time.ZonedDateTime resolver#63
Conversation
- Created JavaZonedDateTimeResolver to generate random ZonedDateTime instances. - Registered JavaZonedDateTimeResolver in SomeConfig.buildResolvers(). - Added comprehensive unit tests for JavaZonedDateTimeResolver. Co-authored-by: MessiasLima <10220064+MessiasLima@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces JavaZonedDateTimeResolver to support resolving ZonedDateTime types, registering it in SomeConfig and adding comprehensive unit tests. The reviewer suggested an optimization to generate a random epoch second directly instead of generating year, day, hour, minute, and second separately, which reduces intermediate object allocations and simplifies the code.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
@jules update the documentation to mention this new resolver |
Documentation has been updated in |
- Added java.time.ZonedDateTime to the list of supported types in docs/supported-types.md. Co-authored-by: MessiasLima <10220064+MessiasLima@users.noreply.github.com>
- Added JavaZonedDateTimeResolver to the resolver registration order in AGENTS.md. Co-authored-by: MessiasLima <10220064+MessiasLima@users.noreply.github.com>
- Replaced ZoneOffset.UTC with a random ZoneId from the available set. Co-authored-by: MessiasLima <10220064+MessiasLima@users.noreply.github.com>
- Optimized ZonedDateTime generation using epoch seconds. - Added detailed KDocs to JavaZonedDateTimeResolver. - Cached available ZoneIds for better performance. Co-authored-by: MessiasLima <10220064+MessiasLima@users.noreply.github.com>
MessiasLima
changed the title
1 participant
This PR adds support for
java.time.ZonedDateTimeto the library.Key changes:
JavaZonedDateTimeResolver: A new resolver that generates randomZonedDateTimevalues between 1970 and 2100 (UTC).SomeConfig.buildResolvers(), maintaining the established order for Java time types.JavaZonedDateTimeResolverTestto verify correct resolution, range constraints, and type rejection.All tests and static analysis (detekt) pass.
Fixes #57
PR created automatically by Jules for task 8048027922549992562 started by @MessiasLima