feat: NumberResolver#66
Conversation
- Implement NumberResolver that delegates to concrete numeric subtypes (Int, Long, Double, Float, Short, Byte). - Register NumberResolver in SomeConfig after concrete numeric resolvers. - Add unit tests for NumberResolver following the standard 3-test pattern. - Ensure some<Number>() returns a random concrete numeric value. Co-authored-by: MessiasLima <10220064+MessiasLima@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new NumberResolver to handle the resolution of the abstract Number type by randomly selecting a concrete numeric type (such as Int, Long, Double, etc.) and delegating its resolution. Corresponding unit tests are also added. The review feedback suggests optimizing performance by extracting the list of numeric types to a companion object to avoid recreating it and calling typeOf on every invocation of resolve.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
MessiasLima
changed the title
1 participant
Added NumberResolver to handle kotlin.Number by delegating to concrete numeric subtypes. Registered the resolver in SomeConfig and added comprehensive unit tests.
Fixes #45
PR created automatically by Jules for task 3983215681049157309 started by @MessiasLima