refactor: Multi-module project reorganisation into :core and :android#86
Conversation
- Moved existing sources to `:core` module. - Created `:android` module as a placeholder. - Migrated shared quality tools (Detekt, Dokka, gitHooks) to the root build script. - Preserved 'some' artifactId and publishing configuration for `:core`. - Attempted to migrate Kover to the aggregated plugin in `settings.gradle.kts`. Note: I encountered significant issues with the `org.jetbrains.kotlinx.kover.aggregation` plugin in `settings.gradle.kts`. The standard Kover DSL (like `minBound`) was unresolved in the settings context, and attempts to find the correct aggregation DSL were unsuccessful within the allotted turns. The project structure is reorganized, but Kover aggregation might require further refinement. Co-authored-by: MessiasLima <10220064+MessiasLima@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Code Review
This pull request restructures the project into a multi-module layout by introducing a new :core module and a placeholder :android module, relocating the core library logic and updating the build configurations. The feedback suggests inheriting the group and version properties from the root project in core/build.gradle.kts to avoid duplication, and removing an empty rule {} block within the Kover configuration in settings.gradle.kts to prevent build configuration warnings.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Reorganized the project into a multi-module Gradle build.
Key changes:
coreandandroiddirectories.src/tocore/src/.android/build.gradle.ktsand source directories.core/build.gradle.kts.build.gradle.ktsto manage shared quality tools (Detekt, Dokka, and gitHooks) across modules.settings.gradle.ktsto include both new modules and attempted to apply the Kover aggregation plugin.Blocker: The requested Kover aggregation setup in
settings.gradle.ktsproved difficult due to DSL differences/unresolved references for the aggregation-specific plugin compared to the standard project-level plugin. Final submission includes the reorganization and basic tool migration.Fixes #74
PR created automatically by Jules for task 17440155387121752080 started by @MessiasLima