CoMorph convection scheme refactoring #178
Description
Are there any linked Issues or Pull Requests?
Pull request: #292
Equivalent change in the UM: MetOffice/um#25
This issue has been migrated from this trac/fcm ticket: lfric_apps:#941
Some aspects of the code-structure also need to be described in documentation, but this hasn't been ported to lfric_apps yet; see: #359.
Brief description
This aims to lodge the first tranch of changes to the CoMorph convection scheme code-base for CoMorph B. In preparation for numerous other issues / pull-requests yet to come to lodge new science, this one just restructures various things to lay the ground work.
The key aim here is to lodge the numerous changes in code-structure from the comorph_dev branch, independent from the new science and the various changes / fixes which affect KGO. This will allow those subsequent things to be viewed as clean diffs against the trunk, making them easier to review and lodge in subsequent pull-requests. While the changes to CoMorph for this issue may look hideously large and widespread, the key thing is that they don't change answers, so they have identically preserved the existing science and technical implementation of CoMorph.
Further details of the issue.
Branch for the Pull Request:
comorph_refact
Branch at stable release versions:
vn3.0_comorph_refact
vn3.1_comorph_refact
Main design changes: Issue-178-Main-Design-Changes
List of minor changes: Issue-178-Minor-Changes
When viewing the diff for each source file in the above branch, I recommend going to the above 2 wiki links and using "search on this page" for the name of the source file in your web browser, to quickly find an explanation of the design changes which have affected that file.
I have now self-reviewed the whole change.