ticket:158 : stevemullerworth : Do not initialise pointers to enable thread-safe LFRic use : defect : general : regression : minor

git-svn-id: https://metomi/svn/socrates.xm/main/trunk@1563 7a691fcb-5d1e-4fc1-8b6b-54125fa6be09

Author: jamesbruten

src/cosp_control/cosp_mod.F90

@@ -175,7 +175,7 @@ subroutine cosp( nlevels, &
   type(cosp_column_inputs) :: cosp_column_in
 
   type(cosp_outputs), target :: cosp_out_int
-  type(cosp_outputs), pointer :: cosp_out => null()
+  type(cosp_outputs), pointer :: cosp_out
 
   character(len=256) :: cosp_status(100)
 

src/interface_core/socrates_runes.F90

@@ -609,10 +609,10 @@ subroutine runes(n_profile, n_layer, diag, &
 
 
 ! Spectral data:
-type(StrSpecData), pointer :: spec => null()
+type(StrSpecData), pointer :: spec
 
 ! Mcica data:
-type(StrMcica), pointer :: mcica => null()
+type(StrMcica), pointer :: mcica
 type(StrMcica), target :: mcica_dummy
 
 ! Controlling options:
@@ -643,6 +643,7 @@ subroutine runes(n_profile, n_layer, diag, &
 character (len=errormessagelength) :: cmessage
 character (len=*), parameter :: RoutineName = 'RUNES'
 
+nullify(spec, mcica)
 
 if (present(spectrum_name)) then
   do id_spec=1, size(spectrum_array)

src/interface_core/socrates_set_spectrum.F90

@@ -65,7 +65,7 @@ subroutine set_spectrum(n_instances, spectrum, spectrum_name, spectral_file, &
 real(RealExt), intent(in), optional :: wavelength_blue
 
 ! Local variables
-type(StrSpecData), pointer :: spec => null()
+type(StrSpecData), pointer :: spec
 integer, parameter :: nd_instances = 2
 integer :: id_spec
 integer :: ierr = i_normal
@@ -79,6 +79,8 @@ subroutine set_spectrum(n_instances, spectrum, spectrum_name, spectral_file, &
 
 if (lhook) call dr_hook(ModuleName//':'//RoutineName,zhook_in,zhook_handle)
 
+nullify(spec)
+
 if (.not.allocated(spectrum_array)) then
   if (present(n_instances)) then
     allocate(spectrum_array(n_instances))
@@ -252,7 +254,7 @@ logical function retain_absorber(ip_absorber, l_absorber)
     implicit none
     integer, intent(in) :: ip_absorber
     logical, intent(in), optional :: l_absorber
-  
+
     if (present(l_absorber)) then
       retain_absorber = (spec%gas%type_absorb(i) == ip_absorber) &
         .and. l_absorber
@@ -339,12 +341,13 @@ subroutine get_spectrum(spectrum_name, spectrum, &
 real(RealExt), allocatable, optional, intent(out) :: weight_blue(:)
 
 ! Local variables
-type(StrSpecData), pointer :: spec => null()
+type(StrSpecData), pointer :: spec
 integer :: id_spec
 integer :: ierr = i_normal
 character(len=errormessagelength) :: cmessage
 character(len=*), parameter :: RoutineName='GET_SPECTRUM'
 
+nullify(spec)
 
 do id_spec=1, size(spectrum_array)
   if (spectrum_array_name(id_spec) == spectrum_name) exit
@@ -404,9 +407,9 @@ subroutine set_mcica(mcica_data_file, sw_spectrum_name, lw_spectrum_name)
 character(len=*), intent(in), optional :: sw_spectrum_name, lw_spectrum_name
 
 ! Local variables
-type(StrSpecData), pointer :: sw_spec => null()
-type(StrSpecData), pointer :: lw_spec => null()
-type(StrMcica), pointer :: mcica => null()
+type(StrSpecData), pointer :: sw_spec
+type(StrSpecData), pointer :: lw_spec
+type(StrMcica), pointer :: mcica
 logical :: l_sw, l_lw
 integer :: id_spec, id_mcica
 integer :: ierr = i_normal
@@ -420,6 +423,8 @@ subroutine set_mcica(mcica_data_file, sw_spectrum_name, lw_spectrum_name)
 
 if (lhook) call dr_hook(ModuleName//':'//RoutineName,zhook_in,zhook_handle)
 
+nullify(sw_spec, lw_spec, mcica)
+
 if (allocated(spectrum_array)) then
   if (.not.allocated(mcica_data_array)) then
     allocate(mcica_data_array(size(spectrum_array)))