From fafbd452dd072b7da4de807357b2eb4fae1437d3 Mon Sep 17 00:00:00 2001
From: Ben Ford <ben.ford@puppetlabs.com>
Date: Sat, 4 Jan 2020 00:22:19 -0800
Subject: [PATCH] Porting functions to the modern Puppet 4.x API

---
 .../functions/hadoop/hadoop_storages.rb       | 60 +++++++++++++++++++
 spec/functions/hadoop_hadoop_storages_spec.rb | 41 +++++++++++++
 2 files changed, 101 insertions(+)
 create mode 100644 lib/puppet/functions/hadoop/hadoop_storages.rb
 create mode 100644 spec/functions/hadoop_hadoop_storages_spec.rb

diff --git a/lib/puppet/functions/hadoop/hadoop_storages.rb b/lib/puppet/functions/hadoop/hadoop_storages.rb
new file mode 100644
index 0000000..676daca
--- /dev/null
+++ b/lib/puppet/functions/hadoop/hadoop_storages.rb
@@ -0,0 +1,60 @@
+# This is an autogenerated function, ported from the original legacy version.
+# It /should work/ as is, but will not have all the benefits of the modern
+# function API. You should see the function docs to learn how to add function
+# signatures for type safety and to document this function using puppet-strings.
+#
+# https://puppet.com/docs/puppet/latest/custom_functions_ruby.html
+#
+# ---- original file header ----
+
+# ---- original file header ----
+#
+# @summary
+#   Parse Hadoop storage array.
+#
+Puppet::Functions.create_function(:'hadoop::hadoop_storages') do
+  # @param arguments
+  #   The original array of arguments. Port this to individually managed params
+  #   to get the full benefit of the modern function API.
+  #
+  # @return [Data type]
+  #   Describe what the function returns here
+  #
+  dispatch :default_impl do
+    # Call the method named 'default_impl' when this is matched
+    # Port this to match individual params for better type safety
+    repeated_param 'Any', :arguments
+  end
+
+
+  def default_impl(*arguments)
+    
+        raise(Puppet::ParseError, "hadoop_storages(): Wrong number of arguments") if arguments.size != 1
+        raise(Puppet::ParseError, "hadoop_storages(): Not an array") if !arguments[0].is_a?(Array)
+
+        storages = arguments[0]
+        ah=[]
+        as=[]
+        storages.each do |s|
+            if !s then
+                raise(Puppet::ParseError, 'hadoop_storages(): Undefined value of the storage path')
+            end
+
+            #[DISK]file:///data/1
+            r = s.scan(/(\[[^\]]*\])?(([A-Za-z0-9]*):\/\/)?(.*)/)[0]
+
+            h = Hash.new()
+            h['type'] = r[0] ? r[0].upcase() : ''
+            h['schema'] = r[2] ? r[2] : 'file'
+            h['path'] = r[3]
+            ah.push(h)
+            as.push(r[3])
+        end
+
+        {
+            'paths' => as,
+            'storages' => ah,
+        }
+    
+  end
+end
diff --git a/spec/functions/hadoop_hadoop_storages_spec.rb b/spec/functions/hadoop_hadoop_storages_spec.rb
new file mode 100644
index 0000000..c090847
--- /dev/null
+++ b/spec/functions/hadoop_hadoop_storages_spec.rb
@@ -0,0 +1,41 @@
+require 'spec_helper'
+
+describe 'hadoop::hadoop_storages' do
+  # without knowing details about the implementation, this is the only test
+  # case that we can autogenerate. You should add more examples below!
+  it { is_expected.not_to eq(nil) }
+
+#################################
+# Below are some example test cases. You may uncomment and modify them to match
+# your needs. Notice that they all expect the base error class of `StandardError`.
+# This is because the autogenerated function uses an untyped array for parameters
+# and relies on your implementation to do the validation. As you convert your
+# function to proper dispatches and typed signatures, you should change the
+# expected error of the argument validation examples to `ArgumentError`.
+#
+# Other error types you might encounter include
+#
+# * StandardError
+# * ArgumentError
+# * Puppet::ParseError
+#
+# Read more about writing function unit tests at https://rspec-puppet.com/documentation/functions/
+#
+#   it 'raises an error if called with no argument' do
+#     is_expected.to run.with_params.and_raise_error(StandardError)
+#   end
+#
+#   it 'raises an error if there is more than 1 arguments' do
+#     is_expected.to run.with_params({ 'foo' => 1 }, 'bar' => 2).and_raise_error(StandardError)
+#   end
+#
+#   it 'raises an error if argument is not the proper type' do
+#     is_expected.to run.with_params('foo').and_raise_error(StandardError)
+#   end
+#
+#   it 'returns the proper output' do
+#     is_expected.to run.with_params(123).and_return('the expected output')
+#   end
+#################################
+
+end