refactor!: Remove providerFromEngine

Author: rekmarks

packages/eth-block-tracker/tests/withBlockTracker.ts

@@ -1,8 +1,4 @@
-import { providerFromEngine } from '@metamask/eth-json-rpc-provider';
-import type {
-  // Eip1193Request,
-  InternalProvider,
-} from '@metamask/eth-json-rpc-provider';
+import { InternalProvider } from '@metamask/eth-json-rpc-provider';
 import { JsonRpcEngine } from '@metamask/json-rpc-engine';
 import type { Json } from '@metamask/utils';
 import util from 'util';
@@ -98,7 +94,7 @@ function getFakeProvider({
     });
   }
 
-  const provider = providerFromEngine(new JsonRpcEngine());
+  const provider = new InternalProvider({ engine: new JsonRpcEngine() });
   jest
     .spyOn(provider, 'request')
     .mockImplementation(async (eip1193Request): Promise<Json> => {

packages/eth-json-rpc-middleware/test/util/helpers.ts

@@ -1,8 +1,5 @@
 import { PollingBlockTracker } from '@metamask/eth-block-tracker';
-import {
-  providerFromEngine,
-  type InternalProvider,
-} from '@metamask/eth-json-rpc-provider';
+import { InternalProvider } from '@metamask/eth-json-rpc-provider';
 import {
   JsonRpcEngine,
   type JsonRpcMiddleware,
@@ -96,7 +93,7 @@ export function createFinalMiddlewareWithDefaultResult<
  */
 export function createProviderAndBlockTracker() {
   const engine = new JsonRpcEngine();
-  const provider = providerFromEngine(engine);
+  const provider = new InternalProvider({ engine });
 
   const blockTracker = new PollingBlockTracker({
     provider,

packages/eth-json-rpc-provider/CHANGELOG.md

@@ -14,9 +14,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   - `SafeEventEmitterProvider` is for now still exported as a deprecated alias of `InternalProvider` for backwards compatibility.
 - **BREAKING:** Use `JsonRpcServer` instead of `JsonRpcEngine` ([#7001](https://github.com/MetaMask/core/pull/7001))
   - Adds a new `server` constructor option to the `InternalProvider` class, mutually exclusive with the now deprecated `engine` option.
-  - Legacy `JsonRpcEngine` instances are wrapped in a `JsonRpcServer` internally
-    wherever they appear. Due to differences in error serialization, this may be
-    breaking for consumers.
+  - Legacy `JsonRpcEngine` instances are wrapped in a `JsonRpcServer` internally wherever they appear.
+    This change should mostly be unobservable. However, due to differences in error handling, this may be breaking for consumers.
+
+### Removed
+
+- **BREAKING:** Remove `providerFromEngine` ([#7001](https://github.com/MetaMask/core/pull/7001))
+  - Use `InternalProvider` directly instead.
 
 ## [5.0.1]
 

packages/eth-json-rpc-provider/src/index.test.ts

@@ -6,7 +6,6 @@ describe('Package exports', () => {
       Array [
         "InternalProvider",
         "SafeEventEmitterProvider",
-        "providerFromEngine",
         "providerFromMiddleware",
         "providerFromMiddlewareV2",
       ]

packages/eth-json-rpc-provider/src/provider-from-engine.test.ts

@@ -12,9 +12,8 @@ import {
   createFetchMiddleware,
   createRetryOnEmptyMiddleware,
 } from '@metamask/eth-json-rpc-middleware';
-import type { InternalProvider } from '@metamask/eth-json-rpc-provider';
 import {
-  providerFromEngine,
+  InternalProvider,
   providerFromMiddleware,
 } from '@metamask/eth-json-rpc-provider';
 import {
@@ -174,7 +173,7 @@ export function createNetworkClient({
 
   engine.push(networkMiddleware);
 
-  const provider = providerFromEngine(engine);
+  const provider = new InternalProvider({ engine });
 
   const destroy = () => {
     // TODO: Either fix this lint violation or explain why it's necessary to ignore.