Update feature flag key

Fix totals.

Author: matthewwalsh0

packages/transaction-pay-controller/src/strategy/bridge/bridge-quotes.test.ts

@@ -127,7 +127,7 @@ describe('Bridge Quotes Utils', () => {
     getRemoteFeatureFlagControllerStateMock.mockImplementation(() => ({
       cacheTimestamp: 0,
       remoteFeatureFlags: {
-        confirmation_pay: getFeatureFlagsMock(),
+        confirmations_pay: getFeatureFlagsMock(),
       },
     }));
 

packages/transaction-pay-controller/src/strategy/bridge/bridge-quotes.ts

@@ -440,7 +440,7 @@ function getFinalRequests(
  */
 function getFeatureFlags(messenger: TransactionPayControllerMessenger) {
   const featureFlags = messenger.call('RemoteFeatureFlagController:getState')
-    .remoteFeatureFlags.confirmation_pay as Record<string, number> | undefined;
+    .remoteFeatureFlags.confirmations_pay as Record<string, number> | undefined;
 
   return {
     attemptsMax: featureFlags?.attemptsMax ?? ATTEMPTS_MAX_DEFAULT,

packages/transaction-pay-controller/src/strategy/relay/relay-quotes.test.ts

@@ -174,7 +174,7 @@ describe('Relay Quotes Utils', () => {
       getRemoteFeatureFlagControllerStateMock.mockReturnValue({
         cacheTimestamp: 0,
         remoteFeatureFlags: {
-          confirmation_pay: {
+          confirmations_pay: {
             relayQuoteUrl,
           },
         },

packages/transaction-pay-controller/src/strategy/relay/relay-quotes.ts

@@ -294,7 +294,7 @@ function getFeatureFlags(messenger: TransactionPayControllerMessenger) {
     'RemoteFeatureFlagController:getState',
   );
 
-  const featureFlags = featureFlagState.remoteFeatureFlags?.confirmation_pay as
+  const featureFlags = featureFlagState.remoteFeatureFlags?.confirmations_pay as
     | Record<string, string>
     | undefined;
 

packages/transaction-pay-controller/src/utils/totals.test.ts

@@ -94,6 +94,25 @@ describe('Totals Utils', () => {
       expect(result.total.usd).toBe('51.08');
     });
 
+    it('returns total excluding token amount not in quote', () => {
+      const result = calculateTotals(
+        [QUOTE_1_MOCK, QUOTE_2_MOCK],
+        [
+          TOKEN_1_MOCK,
+          {
+            ...TOKEN_2_MOCK,
+            balanceRaw: '10',
+            amountRaw: '9',
+            skipIfBalance: true,
+          },
+        ],
+        MESSENGER_MOCK,
+      );
+
+      expect(result.total.fiat).toBe('39.97');
+      expect(result.total.usd).toBe('46.64');
+    });
+
     it('returns provider fees', () => {
       const result = calculateTotals(
         [QUOTE_1_MOCK, QUOTE_2_MOCK],

packages/transaction-pay-controller/src/utils/totals.ts

@@ -50,8 +50,13 @@ export function calculateTotals(
     (quote) => quote.fees.targetNetwork.usd,
   );
 
-  const amountFiat = sumProperty(tokens, (token) => token.amountFiat);
-  const amountUsd = sumProperty(tokens, (token) => token.amountUsd);
+  const quoteTokens = tokens.filter(
+    (t) =>
+      !t.skipIfBalance || new BigNumber(t.balanceRaw).isLessThan(t.amountRaw),
+  );
+
+  const amountFiat = sumProperty(quoteTokens, (token) => token.amountFiat);
+  const amountUsd = sumProperty(quoteTokens, (token) => token.amountUsd);
 
   const totalFiat = new BigNumber(providerFeeFiat)
     .plus(sourceNetworkFeeFiat)