Skip to content

Commit 4f5d575

Browse files
committed
chore: test coverage
1 parent ac287c4 commit 4f5d575

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

src/package-manifest.test.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ describe('package-manifest', () => {
6767
b: '^2.0.0',
6868
c: '~4.3.0',
6969
d: 'workspace:^',
70-
e: 'npm:a@^2.0.0',
70+
e: 'npm:@a/abc@^2.0.0',
7171
},
7272
};
7373
const validated = {
@@ -80,7 +80,7 @@ describe('package-manifest', () => {
8080
b: '^2.0.0',
8181
c: '~4.3.0',
8282
d: 'workspace:^',
83-
e: 'npm:a@^2.0.0',
83+
e: 'npm:@a/abc@^2.0.0',
8484
},
8585
peerDependencies: {},
8686
};
@@ -317,7 +317,9 @@ describe('package-manifest', () => {
317317
name: 'foo',
318318
version: '1.0.0',
319319
peerDependencies: {
320-
a: 12345,
320+
a: 'npm:@foo',
321+
b: 'npm:foo@',
322+
c: '12345',
321323
},
322324
}),
323325
);

src/package-manifest.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,8 @@ function isValidPackageManifestDependencyValue(
174174
try {
175175
const redirectedDependencyMatch = redirectedDependencyRegexp.exec(version);
176176

177-
if (!redirectedDependencyMatch || redirectedDependencyMatch.length < 3) {
177+
/* istanbul ignore if */
178+
if (!redirectedDependencyMatch) {
178179
return false;
179180
}
180181

@@ -183,7 +184,7 @@ function isValidPackageManifestDependencyValue(
183184
validateNPMPackageName(redirectedName)?.validForOldPackages &&
184185
isValidPackageManifestVersionField(redirectedVersion)
185186
);
186-
} catch (e) {
187+
} catch (e) /* istanbul ignore next */ {
187188
return false;
188189
}
189190
}

0 commit comments

Comments
 (0)