fix: apply peer dependency validation without changes to ui

Author: cryptodev-2s

src/release-specification.ts

@@ -172,13 +172,11 @@ export async function waitForUserToEditReleaseSpecification(
  *
  * @param project - The project containing workspace packages.
  * @param packageName - The name of the package to find dependents for.
- * @param unvalidatedReleaseSpecificationPackages - The packages in the release specification.
- * @returns An array of package names that depend on the given package and are missing from the release spec.
+ * @returns An array of package names that depend on the given package.
  */
-export function findMissingUnreleasedDependents(
+export function findAllWorkspacePackagesThatDependOnPackage(
   project: Project,
   packageName: string,
-  unvalidatedReleaseSpecificationPackages: Record<string, string | null>,
 ): string[] {
   const dependentNames = Object.keys(project.workspacePackages).filter(
     (possibleDependentName) => {
@@ -189,6 +187,27 @@ export function findMissingUnreleasedDependents(
     },
   );
 
+  return dependentNames;
+}
+
+/**
+ * Finds all workspace packages that depend on the given package.
+ *
+ * @param project - The project containing workspace packages.
+ * @param packageName - The name of the package to find dependents for.
+ * @param unvalidatedReleaseSpecificationPackages - The packages in the release specification.
+ * @returns An array of package names that depend on the given package and are missing from the release spec.
+ */
+export function findMissingUnreleasedDependents(
+  project: Project,
+  packageName: string,
+  unvalidatedReleaseSpecificationPackages: Record<string, string | null>,
+): string[] {
+  const dependentNames = findAllWorkspacePackagesThatDependOnPackage(
+    project,
+    packageName,
+  );
+
   return dependentNames.filter((dependentName) => {
     return !unvalidatedReleaseSpecificationPackages[dependentName];
   });

src/ui.ts

@@ -10,6 +10,7 @@ import {
 } from './project.js';
 import { Package } from './package.js';
 import {
+  findAllWorkspacePackagesThatDependOnPackage,
   findMissingUnreleasedDependenciesForRelease,
   findMissingUnreleasedDependentsForBreakingChanges,
   IncrementableVersionParts,
@@ -130,15 +131,31 @@ function createApp({
   app.use(express.static(UI_BUILD_DIR));
   app.use(express.json());
 
-  app.get('/api/packages', (_req, res) => {
+  app.get('/api/packages', (req, res) => {
+    const { majorBumps } = req.query;
+
+    const majorBumpsArray =
+      typeof majorBumps === 'string'
+        ? majorBumps.split(',').filter(Boolean)
+        : (req.query.majorBumps as string[] | undefined) || [];
+
+    const requiredDependents = [
+      ...new Set(
+        majorBumpsArray.flatMap((majorBump) =>
+          findAllWorkspacePackagesThatDependOnPackage(project, majorBump),
+        ),
+      ),
+    ];
+
     const pkgs = Object.values(project.workspacePackages).filter(
-      (pkg) => pkg.hasChangesSinceLatestRelease,
+      (pkg) =>
+        pkg.hasChangesSinceLatestRelease ||
+        requiredDependents.includes(pkg.validatedManifest.name),
     );
 
     const packages = pkgs.map((pkg) => ({
       name: pkg.validatedManifest.name,
       version: pkg.validatedManifest.version.version,
-      location: pkg.directoryPath,
     }));
 
     res.json(packages);

src/ui/App.tsx

@@ -1,11 +1,17 @@
 import './style.css';
-import React, { useState, useEffect } from 'react';
+import React, { useState, useEffect, useRef } from 'react';
 import { createRoot } from 'react-dom/client';
 import { SemVer } from 'semver';
 import { ErrorMessage } from './ErrorMessage.js';
 import { PackageItem } from './PackageItem.js';
 import { Package, RELEASE_TYPE_OPTIONS, ReleaseType } from './types.js';
 
+// Helper function to compare sets
+const setsAreEqual = (a: Set<string>, b: Set<string>) => {
+  if (a.size !== b.size) return false;
+  return [...a].every((value) => b.has(value));
+};
+
 type SubmitButtonProps = {
   selections: Record<string, string>;
   packageDependencyErrors: Record<
@@ -67,16 +73,35 @@ function App() {
     new Set(),
   );
   const [showCheckboxes, setShowCheckboxes] = useState(false);
+  const previousPackages = useRef<Set<string>>(new Set());
 
   useEffect(() => {
-    fetch('/api/packages')
+    const majorBumps = Object.entries(selections)
+      .filter(([_, type]) => type === 'major')
+      .map(([pkgName]) => pkgName);
+
+    fetch(`/api/packages?majorBumps=${majorBumps.join(',')}`)
       .then((res) => {
         if (!res.ok) {
           throw new Error(`Received ${res.status}`);
         }
         return res.json();
       })
       .then((data: Package[]) => {
+        const newPackageNames = new Set(data.map((pkg) => pkg.name));
+
+        // Only clean up selections if the package list actually changed
+        if (!setsAreEqual(previousPackages.current, newPackageNames)) {
+          setSelections((prev) =>
+            Object.fromEntries(
+              Object.entries(prev).filter(([pkgName]) =>
+                newPackageNames.has(pkgName),
+              ),
+            ),
+          );
+          previousPackages.current = newPackageNames;
+        }
+
         setPackages(data);
         setLoadingChangelogs(
           data.reduce((acc, pkg) => ({ ...acc, [pkg.name]: false }), {}),
@@ -86,7 +111,7 @@ function App() {
         setError(err.message);
         console.error('Error fetching packages:', err);
       });
-  }, []);
+  }, [selections]);
 
   const checkDependencies = async (selectionData: Record<string, string>) => {
     if (Object.keys(selectionData).length === 0) return;