-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The tool does not detect whether a release already exists #134
Comments
Perhaps in case there is indeed a remote release branch already, the new release branch should be based on the already-existing remote instead of Let's say there is an This would avoid releasing the same packages twice, keeping releases in a queue. This behavior would then be ignored when the user is already on a release branch (#137) |
Ah yes, good point about basing the new branch off the existing branch. I'd imagine we'd probably want to use the latest existing release branch in case there are multiple. |
We discussed this today in review and @mikesposito's solution sounds like it would work fine. There is a risk that if the new release branch is based on the existing branch, the author of the second branch might merge theirs into the first accidentally, and either that would be surprising or the release number would increment by 2 instead of 1. It may be worth it to write up some documentation to address this scenario and offer guidance, but that may be out of scope for this ticket. Regardless it seems we have a path forward. |
When this tool assigns a new version to the project, it takes the current version as specified in
package.json
and increments it. It also uses the same version in the name of the release branch.This works fine if there are no releases in review when the release branch is created. But what if someone has already created a release and somebody else tries to make a new release? Then the version assigned will be the same as the existing one, and when the user tries to push the branch, they will receive an error.
The tool should look for and consider remote release branches when assigning the new version.
The text was updated successfully, but these errors were encountered: