Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When there are many packages that should be included, the error output can be overwhelming #135

Open
mcmire opened this issue Mar 1, 2024 · 0 comments
Labels

Comments

@mcmire
Copy link
Contributor

mcmire commented Mar 1, 2024

If there are error messages for multiple packages, then the output can get pretty overwhelming.

In the following example, I specified that I wanted the release the following packages:

  • @metamask/accounts-controller
  • @metamask/assets-controllers
  • @metamask/keyring-controller
  • @metamask/preferences-controller
  • @metamask/signature-controller
  • @metamask/transaction-controller
  • @metamask/user-operation-controller

And I got this output:

Error: Your release spec could not be processed due to the following issues:

* The following packages, which are dependencies or peer dependencies of the package '@metamask/accounts-controller' being released, are missing from the release spec.

  - @metamask/base-controller

  These packages may have changes that '@metamask/accounts-controller' relies upon. Consider including them in the release spec.

  If you are ABSOLUTELY SURE these packages are safe to omit, however, and want to postpone the release of a package, then list it with a directive of "intentionally-skip". For example:

    packages:
      "@metamask/base-controller": intentionally-skip
* The following packages, which are dependencies or peer dependencies of the package '@metamask/assets-controllers' being released, are missing from the release spec.

  - @metamask/approval-controller
  - @metamask/base-controller
  - @metamask/controller-utils
  - @metamask/network-controller
  - @metamask/polling-controller

  These packages may have changes that '@metamask/assets-controllers' relies upon. Consider including them in the release spec.

  If you are ABSOLUTELY SURE these packages are safe to omit, however, and want to postpone the release of a package, then list it with a directive of "intentionally-skip". For example:

    packages:
      "@metamask/approval-controller": intentionally-skip
      "@metamask/base-controller": intentionally-skip
      "@metamask/controller-utils": intentionally-skip
      "@metamask/network-controller": intentionally-skip
      "@metamask/polling-controller": intentionally-skip
* The following packages, which are dependencies or peer dependencies of the package '@metamask/keyring-controller' being released, are missing from the release spec.

  - @metamask/base-controller
  - @metamask/message-manager

  These packages may have changes that '@metamask/keyring-controller' relies upon. Consider including them in the release spec.

  If you are ABSOLUTELY SURE these packages are safe to omit, however, and want to postpone the release of a package, then list it with a directive of "intentionally-skip". For example:

    packages:
      "@metamask/base-controller": intentionally-skip
      "@metamask/message-manager": intentionally-skip
* The following packages, which are dependencies or peer dependencies of the package '@metamask/preferences-controller' being released, are missing from the release spec.

  - @metamask/base-controller
  - @metamask/controller-utils

  These packages may have changes that '@metamask/preferences-controller' relies upon. Consider including them in the release spec.

  If you are ABSOLUTELY SURE these packages are safe to omit, however, and want to postpone the release of a package, then list it with a directive of "intentionally-skip". For example:

    packages:
      "@metamask/base-controller": intentionally-skip
      "@metamask/controller-utils": intentionally-skip
* The following packages, which are dependencies or peer dependencies of the package '@metamask/signature-controller' being released, are missing from the release spec.

  - @metamask/approval-controller
  - @metamask/base-controller
  - @metamask/controller-utils
  - @metamask/logging-controller
  - @metamask/message-manager

  These packages may have changes that '@metamask/signature-controller' relies upon. Consider including them in the release spec.

  If you are ABSOLUTELY SURE these packages are safe to omit, however, and want to postpone the release of a package, then list it with a directive of "intentionally-skip". For example:

    packages:
      "@metamask/approval-controller": intentionally-skip
      "@metamask/base-controller": intentionally-skip
      "@metamask/controller-utils": intentionally-skip
      "@metamask/logging-controller": intentionally-skip
      "@metamask/message-manager": intentionally-skip
* The following packages, which are dependencies or peer dependencies of the package '@metamask/transaction-controller' being released, are missing from the release spec.

  - @metamask/approval-controller
  - @metamask/base-controller
  - @metamask/controller-utils
  - @metamask/gas-fee-controller
  - @metamask/network-controller

  These packages may have changes that '@metamask/transaction-controller' relies upon. Consider including them in the release spec.

  If you are ABSOLUTELY SURE these packages are safe to omit, however, and want to postpone the release of a package, then list it with a directive of "intentionally-skip". For example:

    packages:
      "@metamask/approval-controller": intentionally-skip
      "@metamask/base-controller": intentionally-skip
      "@metamask/controller-utils": intentionally-skip
      "@metamask/gas-fee-controller": intentionally-skip
      "@metamask/network-controller": intentionally-skip
* The following packages, which are dependencies or peer dependencies of the package '@metamask/user-operation-controller' being released, are missing from the release spec.

  - @metamask/approval-controller
  - @metamask/base-controller
  - @metamask/controller-utils
  - @metamask/gas-fee-controller
  - @metamask/network-controller
  - @metamask/polling-controller

  These packages may have changes that '@metamask/user-operation-controller' relies upon. Consider including them in the release spec.

  If you are ABSOLUTELY SURE these packages are safe to omit, however, and want to postpone the release of a package, then list it with a directive of "intentionally-skip". For example:

    packages:
      "@metamask/approval-controller": intentionally-skip
      "@metamask/base-controller": intentionally-skip
      "@metamask/controller-utils": intentionally-skip
      "@metamask/gas-fee-controller": intentionally-skip
      "@metamask/network-controller": intentionally-skip
      "@metamask/polling-controller": intentionally-skip

Could we combine this somehow?

@mcmire mcmire changed the title Combine error messages When there are many packages that should be included, the error output can be overwhelming Nov 20, 2024
@mcmire mcmire added the enhancement New feature or request label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant