Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release file doesn't always open automatically #144

Open
Mrtenz opened this issue Apr 19, 2024 · 2 comments
Open

Release file doesn't always open automatically #144

Mrtenz opened this issue Apr 19, 2024 · 2 comments
Labels
bug Something isn't working team-wallet-framework

Comments

@Mrtenz
Copy link
Member

Mrtenz commented Apr 19, 2024

A small UX improvement would be to open the release file using the editor of choice. We could have a simple config file in the user's home folder which stores the command to run to open the file, and call that when creating the release file.

@Mrtenz Mrtenz added the enhancement New feature or request label Apr 19, 2024
@mcmire
Copy link
Contributor

mcmire commented Jul 11, 2024

@Mrtenz Right now it checks for EDITOR and uses that first if it's defined:

const { EDITOR } = getEnvironmentVariables();
. Is that enough or do you feel like having a config file would be more reliable?

@mcmire
Copy link
Contributor

mcmire commented Nov 12, 2024

Someone messaged me the other day and said that the tool didn't open an editor for them. They weren't using VSCode, they were using Cursor. So this is definitely still a problem.

We could support a config file, but I am not sure how many people would know about it. We could inform them about it as soon as the tool doesn't detect an editor. By then it would be a bit too late, they'd have to add the config file for next time, but that is definitely an option.

Alternatively, we could have the tool check for alternate editors — and do so by first checking for an executable, then a macOS app. We already check for the existence of code here but we could check for /Applications/Visual Studio Code.app/Contents/Resources/app/bin/code instead, and do a similar thing for Cursor. This way if the user has not installed the code executable it will continue to work.

@mcmire mcmire changed the title Automatically open release file using editor of choice Release file doesn't always open automatically Nov 20, 2024
@mcmire mcmire added bug Something isn't working and removed enhancement New feature or request labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working team-wallet-framework
Projects
None yet
Development

No branches or pull requests

3 participants