-
-
Notifications
You must be signed in to change notification settings - Fork 3
feature: meteor 3 + biome + mocha testing #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jankapunkt
wants to merge
3
commits into
master
Choose a base branch
from
feature/biome
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,41 +1,63 @@ | ||
| name: Test | ||
| on: push | ||
| name: Test suite | ||
| permissions: | ||
| contents: read | ||
|
|
||
| # in this configuration the ci runs only when code is pushed to master branch or a pull request is created | ||
| # in general it is advised to not push to master directly but to create a pull request instead | ||
| on: | ||
| push: | ||
| branches: | ||
| - master | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| test: | ||
| lintcode: | ||
| name: Javascript lint | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| meteorRelease: | ||
| - '--release 1.12.1' | ||
| - '--release 2.1.1' | ||
| - '--release 2.2.3' | ||
| - '--release 2.3.5' | ||
| - '--release 2.4' | ||
| - '--release 2.5.8' | ||
| - '--release 2.6.1' | ||
| - '--release 2.7.3' | ||
| - '--release 2.8.1' | ||
| - '--release 2.9.1' | ||
| - '--release 2.10.0' | ||
| - '--release 2.11.0' | ||
| # Latest version | ||
| - | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v3 | ||
| - name: checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: setup node | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 22 | ||
|
|
||
| - name: Install Node.js | ||
| uses: actions/setup-node@v3 | ||
| - name: cache dependencies | ||
| uses: actions/cache@v4 | ||
| with: | ||
| node-version: '14.x' | ||
| path: ~/.npm | ||
| key: ${{ runner.os }}-node-22-${{ hashFiles('**/package-lock.json') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-node-22- | ||
| - run: | | ||
| npm ci | ||
| npm run lint:check | ||
| npm run format:check | ||
|
|
||
| # at the moment we only test against meteor 3.2.2 | ||
| # because mtest is not working properly with meteor 3+ | ||
| tests: | ||
| name: Meteor ${{ matrix.meteor }} tests | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Install Dependencies | ||
| run: | | ||
| curl https://install.meteor.com | /bin/sh | ||
| npm i -g @zodern/mtest | ||
| - name: Setup meteor | ||
| uses: meteorengineer/setup-meteor@v1 | ||
| with: | ||
| meteor-release: '3.2.2' | ||
|
|
||
| - name: Run Tests | ||
| run: | | ||
| # Retry tests since some of them are flaky | ||
| mtest --package ./ --once ${{ matrix.meteorRelease }} || mtest --package ./ --once ${{ matrix.meteorRelease }} | ||
| - name: cache dependencies | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: ~/.npm | ||
| key: ${{ runner.os }}-node-22-${{ hashFiles('**/package-lock.json') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-node-22- | ||
| - run: | | ||
| ./setupTests.sh | ||
| cd testapp | ||
| npm ci | ||
| npm run test | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| testapp/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| { | ||
| "$schema": "https://biomejs.dev/schemas/2.3.7/schema.json", | ||
| "vcs": { | ||
| "enabled": true, | ||
| "clientKind": "git", | ||
| "useIgnoreFile": true | ||
| }, | ||
| "files": { | ||
| "ignoreUnknown": false, | ||
| "includes": ["**", "!!testapp/"] | ||
| }, | ||
| "formatter": { | ||
| "enabled": true, | ||
| "indentStyle": "tab" | ||
| }, | ||
| "linter": { | ||
| "enabled": true, | ||
| "rules": { | ||
| "recommended": true | ||
| } | ||
| }, | ||
| "javascript": { | ||
| "formatter": { | ||
| "quoteStyle": "double" | ||
| } | ||
| }, | ||
| "assist": { | ||
| "enabled": true, | ||
| "actions": { | ||
| "source": { | ||
| "organizeImports": "on" | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| import { packageName } from '../common' | ||
| import { packageName } from "../common"; | ||
| // Write your package client code here! | ||
|
|
||
| // Variables exported by this module can be imported by other packages and | ||
| // applications. See package-tests-client.js for an example of importing. | ||
| export const name = `${packageName}-client` | ||
| export const name = `${packageName}-client`; | ||
|
|
||
| export default name | ||
| export default name; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| export const packageName = 'template-package' | ||
| export const packageName = "template-package"; | ||
|
|
||
| export default packageName | ||
| export default packageName; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.