Incorrect parsing FTP-string

[mc-butler]

Important

This issue was migrated from Trac:

Origin	https://midnight-commander.org/ticket/1605
Reporter	Hubbitus (@Hubbitus)
Mentions	onlyjob@….fsf.org (@onlyjob)

ENTRY "example.net" URL "/#ftp:examplenet:5wDJP1B/y@example.net"

When I try connect to it I saw:
"ftpfs: making connection to examplenet"
off course this is failed by timeout.

[mc-butler]

Changed by slavazanko (@slavaz) on Jan 1, 1970 at 0:21 UTC

• Blocked by #2361 deleted

(In #2361) Merge [f2ebbd2]

For getting list of commits in branch type:

git log --pretty=oneline fcfa76b..ef676d3

[mc-butler]

Changed by slavazanko (@slavaz) on Dec 1, 2009 at 14:08 UTC (comment 1)

• Owner set to slavazanko
• Status changed from new to accepted

[mc-butler]

Changed by slavazanko (@slavaz) on Dec 1, 2009 at 14:15 UTC (comment 2)

Created branch 1605_incorrect_parsing_ftp_string

Initial [4461cbc55829af3f8cc24611c4a865d12e82c8c4]

Review, please.

[mc-butler]

Changed by slavazanko (@slavaz) on Dec 1, 2009 at 14:15 UTC (comment 3)

• Severity changed from no branch to on review
• Milestone changed from 4.7 to 4.7.0

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Dec 9, 2009 at 14:04 UTC (comment 4)

need search last entry of symbol "@", for correct recognize password with "@" inside. Like this: "/#ftp:examplenet:5@@JP1B/y@example.net"

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Dec 15, 2009 at 9:45 UTC (comment 5)

• Severity changed from on review to on rework

[mc-butler]

Changed by slavazanko (@slavaz) on Dec 15, 2009 at 10:08 UTC (comment 6)

• Severity changed from on rework to on review

• [282a1700ba228353eced454d554b46fc1322456f]: Fixed parce '@' sign into password area of URI.

review.

[mc-butler]

Changed by angel_il (@ilia-maslakov) on Dec 15, 2009 at 17:29 UTC (comment 7)

• Votes set to angel_il

[mc-butler]

Changed by metux (@metux) on Dec 20, 2009 at 16:43 UTC (comment 8)

• Votes changed from angel_il to angel_il metux

should it be rebased (and maybe squeeze the two commits) before merge ?

[mc-butler]

Changed by metux (@metux) on Dec 20, 2009 at 16:48 UTC (comment 9)

rebased it to current master,
please have a quick look at 1605_incorrect_parsing_ftp_string_REBASED before merging it.

[mc-butler]

Changed by slavazanko (@slavaz) on Dec 20, 2009 at 23:10 UTC (comment 10)

Of course, branch need to rebase. But decision of rebasing is taken by the owner of the branch.

Don't worry about rebasing - you may reminder about this into comments into ticket. No need to create new branch.

Also, branch stay into 'on review' status. Is need for third vote to this branch or you just forgot to change status to 'approved'?

[mc-butler]

Changed by andrew_b (@aborodin) on Dec 22, 2009 at 8:25 UTC (comment 11)

• Severity changed from on review to approved

[mc-butler]

Changed by slavazanko (@slavaz) on Dec 22, 2009 at 9:00 UTC (comment 12)

• Votes changed from angel_il metux to commited-master
• Resolution set to fixed
• Status changed from accepted to testing
• Severity changed from approved to merged

Merge [204b8ac]

[mc-butler]

Changed by slavazanko (@slavaz) on Dec 22, 2009 at 9:01 UTC (comment 13)

• Status changed from testing to closed