Skip to content

Commit 857a08e

Browse files
committed
Issue-94 Resolved memory leak by adding weak to parent CameraManager
1 parent 10cde2e commit 857a08e

File tree

6 files changed

+6
-6
lines changed

6 files changed

+6
-6
lines changed

Sources/Internal/Manager/CameraManager+MotionManager.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import CoreMotion
1313
import AVKit
1414

1515
@MainActor class CameraManagerMotionManager {
16-
private(set) var parent: CameraManager!
16+
private(set) weak var parent: CameraManager!
1717
private(set) var manager: CMMotionManager = .init()
1818
}
1919

Sources/Internal/Manager/CameraManager+NotificationCenter.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
import Foundation
1313

1414
@MainActor class CameraManagerNotificationCenter {
15-
private(set) var parent: CameraManager!
15+
private(set) weak var parent: CameraManager!
1616
}
1717

1818
// MARK: Setup

Sources/Internal/Manager/CameraManager+PhotoOutput.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
import AVKit
1313

1414
@MainActor class CameraManagerPhotoOutput: NSObject {
15-
private(set) var parent: CameraManager!
15+
private(set) weak var parent: CameraManager!
1616
private(set) var output: AVCapturePhotoOutput = .init()
1717
}
1818

Sources/Internal/Manager/CameraManager+VideoOutput.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import SwiftUI
1414
import MijickTimer
1515

1616
@MainActor class CameraManagerVideoOutput: NSObject {
17-
private(set) var parent: CameraManager!
17+
private(set) weak var parent: CameraManager!
1818
private(set) var output: AVCaptureMovieFileOutput = .init()
1919
private(set) var timer: MTimer = .init(.camera)
2020
private(set) var recordingTime: MTime = .zero

Sources/Internal/UI/Camera View/CameraView+Grid.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
import SwiftUI
1313

1414
class CameraGridView: UIView {
15-
var parent: CameraManager!
15+
weak var parent: CameraManager!
1616
}
1717

1818
// MARK: Setup

Sources/Internal/UI/Camera View/CameraView+Metal.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import MetalKit
1414
import AVKit
1515

1616
@MainActor class CameraMetalView: MTKView {
17-
private(set) var parent: CameraManager!
17+
private(set) weak var parent: CameraManager!
1818
private(set) var ciContext: CIContext!
1919
private(set) var commandQueue: MTLCommandQueue!
2020
private(set) var currentFrame: CIImage?

0 commit comments

Comments
 (0)