Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcr_config is limited and doesn't support all options supported in daemon.json #73

Open
vishghelani opened this issue Jan 21, 2025 · 1 comment

Comments

@vishghelani
Copy link

Is your feature request related to a problem? Please describe.
I would like to use this terraform provider in-lieu of a direct launchpad execution so that i can leverage terraforms state management (i.e. launchpad only runs when there is a legitimate change to act on. In launchpad I can provide a YAML map via mcrConfig that allows me to pass in more information to the daemon.json file that is generated by launchpad, e.g:

  "data-root": 
  "default-address-pools":
  - "base": 
    "size": 
  "insecure-registries":
  -
  "log-driver": "json-file"
  "log-opts":
    "max-file": "3"
    "max-size": "100m"
  "storage-driver": "overlay2"

the mcr_config attribute in the terraform provider only allows for 3 attributes:

    debug 
    bip  
    default_address_pool

Describe the solution you'd like
Is it possible to modify this provider so that these other attributes can also be passed in or ideally so that any attributes supported in the daemon.json file can be passed in

Describe alternatives you've considered
we don't currently have an alternative to this as our launchpad execution is resulting in downtime in our production environment due to MCR restarting every-time we run the pipeline due to the config being generated within a terraform run and launchpad being executed everytime regardless of whether a change in the launchpad config has occurred

Additional context
Add any other context or screenshots about the feature request here.

Copy link
Contributor

Thank you for submitting an issue to the Mirantis Launchpad Provider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant