Skip to content

Auto-release does not work with PRs from forks #209

Description

@jcpitre

Normally the Auto Release on Schema Changes GH workflow is run when there is a PR merge.

After merging #208, it failed to run properly. See Failing run (expires after a while)

So there was no release for the PR.

Cause: the workflow triggers on pull_request: [closed] does not work for branches from forked repos because of a permission problem

Fix: trigger on push: branches: [master] instead.
Apparently this trigger does not suffer from this problem. Make sure though that you need a PR to merge on master, i.e. no direct commits on master (I could not verify this myself).
As an added benefit this trigger can be provided a pattern for folder for which changes should trigger.
Currently the filtering is done within the worflow steps. See auto_release_on_json_schema_change.yml
That part could be replaced by the trigger filtering.

As an added possible change, the current workflow automatically increments the patch section in the version. major.minor.patch. e.g. 4.3.0->4.3.1
It should probably increment at least the minor version, since it's a change in the schemas.

Workaround: Release manually.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions