Make it give the player the shard item

Author: Tomate0613

src/main/java/net/modfest/scatteredshards/client/command/CreateInstantCommand.java

@@ -13,7 +13,7 @@
 import net.modfest.scatteredshards.api.shard.ShardType;
 import net.modfest.scatteredshards.command.ShardCommand;
 import net.modfest.scatteredshards.command.ShardCommandNodeHelper;
-import net.modfest.scatteredshards.networking.C2SModifyShard;
+import net.modfest.scatteredshards.networking.C2SCreateShardInstant;
 import net.modfest.scatteredshards.util.ModMetaUtil;
 
 import static net.modfest.scatteredshards.client.command.ClientShardCommand.identifierArgument;
@@ -51,7 +51,7 @@ public static int create(CommandContext<FabricClientCommandSource> ctx) throws C
 		shard.setIcon(modIcon);
 		shard.setSourceId(Identifier.of(modId, "shard_pack"));
 
-		ClientPlayNetworking.send(new C2SModifyShard(shardId, shard));
+		ClientPlayNetworking.send(new C2SCreateShardInstant(shardId, shard));
 
 		source.sendFeedback(Text.translatable("commands.scattered_shards.shard.create_instant", shardId.toString()));
 

src/main/java/net/modfest/scatteredshards/networking/C2SCreateShardInstant.java

@@ -0,0 +1,61 @@
+package net.modfest.scatteredshards.networking;
+
+import me.lucko.fabric.api.permissions.v0.Permissions;
+import net.fabricmc.fabric.api.networking.v1.ServerPlayNetworking;
+import net.minecraft.network.RegistryByteBuf;
+import net.minecraft.network.codec.PacketCodec;
+import net.minecraft.network.packet.CustomPayload;
+import net.minecraft.server.MinecraftServer;
+import net.minecraft.server.network.ServerPlayerEntity;
+import net.minecraft.util.Identifier;
+import net.modfest.scatteredshards.ScatteredShards;
+import net.modfest.scatteredshards.api.ScatteredShardsAPI;
+import net.modfest.scatteredshards.api.impl.ShardLibraryPersistentState;
+import net.modfest.scatteredshards.api.shard.Shard;
+import net.modfest.scatteredshards.block.ShardBlock;
+
+/**
+ * Requests that a shard be created. Requires permissions!
+ */
+public record C2SCreateShardInstant(Identifier shardId, Shard shard) implements CustomPayload {
+	public static final Id<C2SCreateShardInstant> PACKET_ID = new Id<>(ScatteredShards.id("create_shard_instant"));
+	public static final PacketCodec<RegistryByteBuf, C2SCreateShardInstant> PACKET_CODEC = PacketCodec.tuple(Identifier.PACKET_CODEC, C2SCreateShardInstant::shardId, Shard.PACKET_CODEC, C2SCreateShardInstant::shard, C2SCreateShardInstant::new);
+
+	public static void receive(C2SCreateShardInstant payload, ServerPlayNetworking.Context context) {
+		// TODO: This is mostly identical to C2SModifyShard, no need for so much duplicate code
+
+		MinecraftServer server = context.player().getServer();
+		server.execute(() -> {
+			boolean success = server.isSingleplayer() || Permissions.check(context.player(), ScatteredShardsAPI.MODIFY_SHARD_PERMISSION, 1);
+
+			//Let the sender know of success or failure before a shard update comes through
+			ServerPlayNetworking.send(context.player(), new S2CModifyShardResult(payload.shardId(), success));
+
+			if (!success) {
+				return;
+			}
+
+			//Update our serverside library
+			var library = ScatteredShardsAPI.getServerLibrary();
+			library.shards().put(payload.shardId(), payload.shard());
+			library.shardSets().put(payload.shard().sourceId(), payload.shardId());
+
+			//Make sure the NBT gets written on next world-save
+			ShardLibraryPersistentState.get(server).markDirty();
+
+			//Update everyone's client libraries with the new shard
+			S2CSyncShard syncShard = new S2CSyncShard(payload.shardId(), payload.shard());
+			for (ServerPlayerEntity otherPlayer : server.getPlayerManager().getPlayerList()) {
+				ServerPlayNetworking.send(otherPlayer, syncShard);
+			}
+
+			var itemStack = ShardBlock.createShardBlock(library, payload.shardId(), false, 0.5f, 0.5f);
+			context.player().getInventory().offerOrDrop(itemStack);
+		});
+	}
+
+	@Override
+	public Id<? extends CustomPayload> getId() {
+		return PACKET_ID;
+	}
+}

src/main/java/net/modfest/scatteredshards/networking/ScatteredShardsNetworking.java

@@ -28,11 +28,13 @@ public static void register() {
 		PayloadTypeRegistry.playS2C().register(S2CSyncCollection.PACKET_ID, S2CSyncCollection.PACKET_CODEC);
 		PayloadTypeRegistry.playS2C().register(S2CSyncGlobalCollection.PACKET_ID, S2CSyncGlobalCollection.PACKET_CODEC);
 		PayloadTypeRegistry.playC2S().register(C2SModifyShard.PACKET_ID, C2SModifyShard.PACKET_CODEC);
+		PayloadTypeRegistry.playC2S().register(C2SCreateShardInstant.PACKET_ID, C2SCreateShardInstant.PACKET_CODEC);
 		PayloadTypeRegistry.playC2S().register(C2SRequestGlobalCollection.PACKET_ID, C2SRequestGlobalCollection.PACKET_CODEC);
 		PayloadTypeRegistry.playS2C().register(S2CModifyShardResult.PACKET_ID, S2CModifyShardResult.PACKET_CODEC);
 		PayloadTypeRegistry.playS2C().register(S2CUpdateShard.PACKET_ID, S2CUpdateShard.PACKET_CODEC);
 
 		ServerPlayNetworking.registerGlobalReceiver(C2SModifyShard.PACKET_ID, C2SModifyShard::receive);
+		ServerPlayNetworking.registerGlobalReceiver(C2SCreateShardInstant.PACKET_ID, C2SCreateShardInstant::receive);
 		ServerPlayNetworking.registerGlobalReceiver(C2SRequestGlobalCollection.PACKET_ID, C2SRequestGlobalCollection::receive);
 
 		ServerPlayConnectionEvents.JOIN.register((handler, sender, server) -> {