Release v1.2.13.2 updater version fix

Signed-off-by: moontheripper <moontheripper@users.noreply.github.com>

Author: MoonTheRipper

Sources/RipperMoonKitLauncher/RipperMoonKitLauncherApp.swift

@@ -26,11 +26,21 @@ private enum SidebarSelection: Hashable {
     case settings
 }
 
-private let rmkAppVersion: String =
-    (Bundle.main.object(forInfoDictionaryKey: "CFBundleShortVersionString") as? String) ?? "1.0"
+private let rmkAppVersion: String = resolvedRipperMoonKitVersion()
 
 private let rmkRepositoryURL = "https://github.com/MoonTheRipper/RipperMoonKit.git"
 
+private func resolvedRipperMoonKitVersion() -> String {
+    let bundledVersion = Bundle.main.bundleURL
+        .appendingPathComponent("Contents/Resources/toolkit/VERSION")
+    if let raw = try? String(contentsOf: bundledVersion, encoding: .utf8) {
+        let version = raw.trimmingCharacters(in: .whitespacesAndNewlines)
+        if !version.isEmpty { return version }
+    }
+
+    return (Bundle.main.object(forInfoDictionaryKey: "CFBundleShortVersionString") as? String) ?? "1.0"
+}
+
 private struct UpdateNotice: Identifiable, Equatable {
     let version: String
     let url: URL
@@ -4052,13 +4062,35 @@ private final class LauncherModel: ObservableObject {
     }
 
     func updateFromGitHub() {
+        let source = toolkitSourceFolder.shellQuoted
+        let repo = rmkRepositoryURL.shellQuoted
         let command = """
         \(toolkitSourceBootstrapCommand)
-        if [[ -d .git ]]; then
+        src=\(source)
+        repo=\(repo)
+        if [[ -d "$src/.git" ]]; then
+          cd "$src"
           git fetch --tags origin && \
           if [[ "$(git rev-parse HEAD)" != "$(git rev-parse origin/main)" ]]; then git pull --ff-only origin main; else echo "Already up to date."; fi
         else
-          echo "Toolkit source exists without Git metadata; using installed source as-is."
+          echo "Toolkit source has no Git metadata; replacing it with a fresh GitHub checkout."
+          parent="$(dirname "$src")"
+          stamp="$(date +%Y%m%d-%H%M%S)"
+          mkdir -p "$parent"
+          rm -rf "$src.update" "$src.update.zip"
+          if git --version >/dev/null 2>&1; then
+            git clone --depth 1 "$repo" "$src.update"
+          else
+            curl -fL "https://github.com/MoonTheRipper/RipperMoonKit/archive/refs/heads/main.zip" -o "$src.update.zip"
+            unzip -q "$src.update.zip" -d "$parent"
+            mv "$parent/RipperMoonKit-main" "$src.update"
+            rm -f "$src.update.zip"
+          fi
+          if [[ -e "$src" ]]; then
+            mv "$src" "$src.previous-$stamp"
+          fi
+          mv "$src.update" "$src"
+          cd "$src"
         fi
         ./install.zsh --skip-deps && \
         zsh scripts/install-gui-app.zsh

VERSION

@@ -1 +1 @@
-1.2.13.1
+1.2.13.2

docs/troubleshooting.html

@@ -63,6 +63,10 @@ <h2>macOS Says The App Is Damaged Or Cannot Be Opened</h2>
       <p>Download the newest DMG from GitHub releases first. Older packages before <code>v1.2.3</code> could contain an app bundle whose internal resources were not sealed correctly, so a fresh macOS user account could reject the app even when the developer account opened it.</p>
       <p>If the newest DMG still fails, remove the old copy from Applications, drag the app from the DMG into Applications again, then open <strong>System Settings &gt; Privacy &amp; Security</strong> and allow the app if macOS asks. RipperMoonKit is ad-hoc signed for now, not Apple Developer ID notarized.</p>
 
+      <h2>Update Banner Still Appears After Updating</h2>
+      <p>If the app says an update is available, runs <strong>Update From GitHub</strong>, relaunches, and still shows the same update, install the newest DMG from GitHub releases.</p>
+      <p>The <code>v1.2.13.1</code> app could rebuild from its bundled support source when the local support folder was not a Git checkout. That made the app relaunch the old build even though GitHub had a newer release. <code>v1.2.13.2</code> fixes this by replacing a non-Git support source with a fresh GitHub checkout before rebuilding, and by reading the installed app version from the bundled <code>VERSION</code> file.</p>
+
       <h2>GPTK Shows Missing</h2>
       <p>Make sure Game Porting Toolkit is installed or mounted. The launcher accepts configured GPTK paths, the Apple app in <code>/Applications</code>, and patched runners under <code>$GPTK_HOME/runners</code>.</p>
 

docs/troubleshooting.md

@@ -6,6 +6,12 @@ Download the newest DMG from GitHub releases first. Older packages before `v1.2.
 
 If the newest DMG still fails, remove the old copy from Applications, drag the app from the DMG into Applications again, then open **System Settings > Privacy & Security** and allow the app if macOS asks. RipperMoonKit is ad-hoc signed for now, not Apple Developer ID notarized.
 
+## Update Banner Still Appears After Updating
+
+If the app says an update is available, runs **Update From GitHub**, relaunches, and still shows the same update, install the newest DMG from GitHub releases.
+
+The `v1.2.13.1` app could rebuild from its bundled support source when the local support folder was not a Git checkout. That made the app relaunch the old build even though GitHub had a newer release. `v1.2.13.2` fixes this by replacing a non-Git support source with a fresh GitHub checkout before rebuilding, and by reading the installed app version from the bundled `VERSION` file.
+
 ## Steam Starts But Webhelper Times Out
 
 Repair Steam compatibility:

index.html

@@ -490,7 +490,7 @@
           <img src="docs/assets/rippermoonlogo.png" alt="RipperMoonKit">
           <span class="brand-name">RipperMoonKit</span>
         </a>
-        <span class="pill mono" data-release-version>v1.2.13.1</span>
+        <span class="pill mono" data-release-version>v1.2.13.2</span>
         <div class="nav-links">
           <a href="#features">Features</a>
           <a href="#games">Games</a>
@@ -530,7 +530,7 @@ <h1>Reap the wine prefix.<br><span class="dim">Run Windows games clean on macOS.
         </a>
         <span class="ship">
           <span class="pulse"></span>
-          <span><strong data-release-version>v1.2.13.1</strong> · free personal use · source available</span>
+          <span><strong data-release-version>v1.2.13.2</strong> · free personal use · source available</span>
         </span>
       </div>
     </header>