Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#define OLC_PGE_APPLICATION line can have miscellaneous text surrounding it (No Side Effects) - Bug in Version: aee3eb2 #78

Closed
sigonasr2 opened this issue May 28, 2024 · 2 comments · Fixed by #79
Assignees
Labels
bug Something isn't working

Comments

@sigonasr2
Copy link

Describe the bug
Typing anything before or after #define OLC_PGE_APPLICATION is considered legal, but does not appear to have any other consequences.

To Reproduce
Steps to reproduce the behavior:

  1. Start PGEtinker with the default code.
  2. On the top line with #define OLC_PGE_APPLICATION, write any text of your desires either before or after it.
  3. Click Run and see that it builds fine with no side effects.

Expected behavior
Probably should error with an invalid name/type/symbol error of some sort from the compiler?

Additional context
Here is an example PGEtinker share demonstrating the "problem": https://beta.pgetinker.com/s/L-YwkrmuLLV

@sigonasr2 sigonasr2 added the bug Something isn't working label May 28, 2024
@Moros1138
Copy link
Owner

First. Thank you for almost always giving me a direct example I can use to test.. It really helps me to quickly identify the issue.

Second. I know why this happens.

https://github.com/Moros1138/PGEtinker/blob/main/pgetinker/Compiler.php#L180

I'll refine this check to do it in a less naive way. Thanks again.

@Moros1138
Copy link
Owner

This fix has been deployed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants