bug: CLI 1.6.4-dev.2 can not purge temporary file (windows memory map issue)

[chihafuyu]

Bug description

I am using the CLI from this PR: #108 (here is the artifact: https://github.com/MorpheApp/morphe-cli/actions/runs/24078851888/artifacts/6304612173). However, it cannot purge temporary files for universal .apk files, though it purges them normally for bundles like .apkm (e.g., Reddit).

Error logs

Solution

No response

Additional context

The CLI from https://github.com/MorpheApp/morphe-cli/releases/tag/v1.6.4-dev.2 worked fine, though. It can purge temporary files for all apps.

Acknowledgements

• I have checked all open and closed bug reports and this is not a duplicate.
• I have chosen an appropriate title.

[prateek-who]

Could you try the latest dev release and see if your issue is fixed?

[chihafuyu]

Sorry for being late reply, my account was flagged by github's bot almost 2 months.

Recent tested, still it can not purge temp. files for universal .apk e.g YouTube.

[prateek-who]

Yea, your issue randomly popped up and I was wondering why that happened.
I feel this should solve the issue now. If it still isn't fixed, then feel free to report it back here. (Heads up, all the morphe contents have been moved to a folder called "morphe-data" that gets made in the same folder as the jar file is present. They keystore has also been unified, so no more separate keystores for each app too. Try this build once and see if it solves your issue.)

[chihafuyu]

Still does not work for universal .apk but works for .apkm file.
morphe-data folder still contains dex from YouTube.apk and YouTube Music.apk, but not for Reddit.apkm

INFO: Morphe data root: C:\Apks\morphe-data (JAR-adjacent)
INFO: Loading patches...
INFO: Reading options from C:\Apks\Morphe\youtube-options-dev.json
INFO: Initializing patcher...
INFO: Filtering patches for com.google.android.youtube v21.22.165...
INFO: Skipping disabled: Override certificate pinning (from options file)
INFO: Skipping disabled: Change package name (from options file)
INFO: Skipping disabled: Disable Play Store updates (from options file)
INFO: Applying 69 patches...
INFO: Deleting existing temporary files directory
INFO: Decoding all resources
INFO: Sanitizing unpatched strings
INFO: Escaping strings
INFO: Executing patches
INFO: Applied: Alternative thumbnails
INFO: Applied: Ambient mode
INFO: Applied: Bypass URL redirects
INFO: Applied: Bypass image region restrictions
INFO: Applied: Captions
INFO: Applied: Change form factor
INFO: Applied: Change header
INFO: Applied: Change start page
INFO: Applied: Check watch history domain name resolution
INFO: Applied: Copy video URL
INFO: Applied: Custom branding
INFO: Applied: Custom player overlay opacity
INFO: Applied: Disable DRC audio
INFO: Applied: Disable QUIC protocol
INFO: Applied: Disable Shorts resuming on startup
INFO: Applied: Disable double tap actions
INFO: Applied: Disable haptic feedback
INFO: Applied: Disable layout updates
INFO: Applied: Disable player popup panels
INFO: Applied: Disable rolling number animations
INFO: Applied: Disable sign in to TV popup
INFO: Applied: Disable video codecs
INFO: Applied: Double tap to seek
INFO: Applied: Downloads
INFO: Applied: Enable debugging
INFO: Applied: Exit fullscreen mode
INFO: Applied: Force original audio
INFO: Applied: GmsCore support
INFO: Applied: Hide Shorts components
INFO: Applied: Hide ads
INFO: Applied: Hide autoplay preview
INFO: Applied: Hide end screen cards
INFO: Applied: Hide end screen suggested video
INFO: Applied: Hide info cards
INFO: Applied: Hide layout components
INFO: Applied: Hide player flyout menu components
INFO: Applied: Hide player overlay buttons
INFO: Applied: Hide related video overlay
INFO: Applied: Hide related videos
INFO: Applied: Hide timestamp
INFO: Applied: Hide video action buttons
INFO: Applied: Loop video
INFO: Applied: Media notification controls
INFO: Applied: Miniplayer
INFO: Applied: Navigation bar
INFO: Applied: Open Shorts in regular player
INFO: Applied: Open channel of live avatar
INFO: Applied: Open links externally
INFO: Applied: Open system share sheet
INFO: Applied: Open videos fullscreen
INFO: Applied: Override YouTube Music buttons
INFO: Applied: Play all
INFO: Applied: Playback speed
INFO: Applied: Reload video
INFO: Applied: Remove background playback restrictions
INFO: Applied: Remove viewer discretion dialog
INFO: Applied: Return YouTube Dislike
INFO: Applied: Sanitize sharing links
INFO: Applied: Save to watch later
INFO: Applied: Seekbar
INFO: Applied: Shorts autoplay
INFO: Applied: SponsorBlock
INFO: Applied: Spoof app version
INFO: Applied: Spoof device dimensions
INFO: Applied: Spoof video streams
INFO: Applied: Swipe controls
INFO: Applied: Theme
INFO: Applied: Video ads
INFO: Applied: Video quality
INFO: Compiling patched dex files (mode: FULL)
INFO: Processing 56545 classes in parallel (4 threads)
INFO: Wrote 9 dex files to C:\Apks\morphe-data\tmp\patching-1780582083808\patched\dex
INFO: Compiling modified resources
INFO: Stripping libs (keeping architectures arm64-v8a)
INFO: Stripped 102 lib files
INFO: Unescaping strings
INFO: Post-processing package name change
INFO: Processing aapt macros
INFO: Generating new resource IDs
INFO: Writing resource APK
INFO: Aligning APK
INFO: Signing APK
INFO: Saved to C:\Apks\Morphe\Output\YouTube_Morphe_21.22.165-arm64-v8a.apk
INFO: Patching result saved to C:\Apks\Morphe\Output\temp_result_YouTube.json
WARNING: Failed to purge C:\Apks\morphe-data\tmp\patching-1780582083808

[prateek-who]

Checking this now

[prateek-who]

This is the memory mapped file issue. Unfortunately this is a limitation of how windows handles files. Windows doesn't allow for file deletion when a file is memory mapped. The workaround for now is to manually delete files after running the CLI. We'll keep this issue open incase we can find a solution in the future.

[wchill]

Will be fixed in MorpheApp/morphe-patcher#143