Merge pull request #69 from courtneycb/polygonChanges

Adds checks for nulls when parsing offsetPath.

Author: courtneycb

karma.conf.js

@@ -23,7 +23,7 @@ module.exports = function(config) {
         'tools/internal-scope.js',
       ],
       require('fs').readFileSync('src/fileOrder.txt', 'utf8').split('\n'),
-      ['test/*.js']
+      ['test/testFunctions.js', 'test/basicShapePolygonTest.js']
     ),
 
     // list of files to exclude

src/offsetPath.js

@@ -42,7 +42,7 @@
     // TODO: Need to support other positions as currently this only supports positions in which both x and y are specified and are in px
     if (position === null) {
       // TODO: Set default position to the center of the reference box
-      position = [0, 0];
+      position = '0px 0px';
       if (input !== '') {
         radius = input;
       }
@@ -89,6 +89,7 @@
     var isInArray = internalScope.isInArray;
     var parseAngleAsDegrees = internalScope.parseAngleAsDegrees;
     var ray = /^ray\((.*)\)$/.exec(input);
+
     if (ray === null) {
       return undefined;
     }

test/basicShapePolygonTest.js

@@ -16,6 +16,18 @@
       result = offsetPathParse('polygon(50px 0px, 50px -50px, 0px -50px)');
       assert.equal(offsetPathParse(result.path, 'm 50 0 l 0 -50 l -50 0 z'));
 
+      result = offsetPathParse('garbage');
+      assert.equal(offsetPathParse(result, undefined));
+
+      result = offsetPathParse('polygon');
+      assert.equal(offsetPathParse(result, undefined));
+
+      result = offsetPathParse('polygon()');
+      assert.equal(offsetPathParse(result, undefined));
+
+      result = offsetPathParse('polygon(garbage)');
+      assert.equal(offsetPathParse(result, undefined));
+
       assertTransformInterpolation([
                                     {'offsetPath': 'polygon(0px 0px, 50px 0px, 50px -50px, 0px -50px)', 'offsetDistance': '0%'},
                                     {'offsetPath': 'polygon(0px 0px, 50px 0px, 50px -50px, 0px -50px)', 'offsetDistance': '100%'}],