Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Pressing trigger key after clicking on desktop triggers alert sound #561

Closed
4 tasks done
greg1075 opened this issue Sep 16, 2024 · 4 comments · Fixed by #571
Closed
4 tasks done

🐞 Pressing trigger key after clicking on desktop triggers alert sound #561

greg1075 opened this issue Sep 16, 2024 · 4 comments · Fixed by #571
Assignees
Labels

Comments

@greg1075
Copy link

Bug Description

Pressing the trigger set in Loop > Keybindings while the desktop/Finder is the focused application triggers the system alert sound.

Steps To Reproduce

  1. With Loop open, click on desktop
  2. Press Loop trigger key

Expected Behavior

No sound trigger

Actual Behavior

Pressing the trigger set in Loop > Keybindings while the desktop/Finder is the focused application triggers the system alert sound.

Screenshots

No response

macOS Version

macOS Sequoia 15.0 (24A335)

Loop Version

Version 1.2.0 (1298)

Additional Context

No response

Final Checks

  • My issue is written in English
  • My issue title is descriptive
  • This is a single bug (multiple bugs should be reported individually)
  • I can help with fixing or developing this issue (tick if you can help).
@greg1075 greg1075 added the Bug label Sep 16, 2024
@MrKai77
Copy link
Owner

MrKai77 commented Sep 16, 2024

If there is no window focused, Loop will play an alert sound indicating that there is no window to be resized. However, are you facing this with finder windows focused as well?

@greg1075
Copy link
Author

Just when there is no window focused, sorry for the confusion. I don't remember this happening before, so I thought that was introduced in one of the recent updates.

That said, I'd suggest removing the alert altogether. I don't find particularly useful (if no window is focused, nothing happens and that's that). It is also annoying to have the alert triggered every time I use a keyboard shortcut that uses the same trigger key. Ex: I use the left command key to trigger Loop keybinds, which means that the alert sound is triggered every time I invoke spotlight (command + space) and a few other shortcuts that uses the left command key.

@MrKai77
Copy link
Owner

MrKai77 commented Sep 17, 2024

Actually, that makes a lot of sense. Even a visual indicator on top of the radial menu indicating that there's not a focused window makes more sense than producing sound!

@greg1075
Copy link
Author

I use Spotlight dozens of times a day, and getting the alert sound every time was getting pretty annoying. For now I've turned its volume all the way down. Looking forward to a fix soon :)

@MrKai77 MrKai77 self-assigned this Sep 26, 2024
@MrKai77 MrKai77 linked a pull request Sep 26, 2024 that will close this issue
@MrKai77 MrKai77 changed the title Pressing trigger key after clicking on desktop triggers alert sound 🐞 Pressing trigger key after clicking on desktop triggers alert sound Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants