Skip to content

Commit f07a319

Browse files
authored
👷 Align aggregate checks with closed pull request jobs (#477)
🤖 *AI text below* 🤖 ## Description Allow the aggregate `🚦 Check` job to accept skipped test, lint, and template jobs on `pull_request: closed` events. The producer jobs already skip closed pull requests, while the aggregate job previously allowed skips only when change detection marked a job irrelevant. After #476 merged, change detection correctly marked template CI as relevant, the template job skipped because the event was `closed`, and the aggregate job incorrectly treated that skip as a failure in [run 30399676581](https://github.com/Munich-Quantum-Software-Stack/QDMI/actions/runs/30399676581). The allowed-skip expressions now mirror the producer job conditions: tests, lint, and templates may skip on closed events or when their path filters disable them. Documentation remains unchanged because its closed-event path may remove the pull request preview. Other pull request events, pushes, merge-group runs, and manual runs continue to require every relevant job. ## Validation - `uvx prek run -a` - `git diff --check` - Independent read-only review of the closed/non-closed event truth table and documentation cleanup path The definitive hosted regression check is this pull request's own `closed` run after merge. ## Checklist - [x] The pull request only contains commits that are focused and relevant to this change. - [x] The workflow's existing aggregate gate covers the changed behavior. - [x] Documentation changes are not required for this CI-only correction. - [x] A changelog entry is not warranted because there is no user-facing behavior change. - [x] Migration instructions are not needed. - [x] The changes follow the project's style guidelines and introduce no new warnings. - [x] The changes passed the relevant local validation listed above. - [x] The code changes have been independently reviewed. **If PR contains AI-assisted content:** - [x] AI assistance is disclosed at the beginning of this description. - [x] The AI-assisted commit includes the required `Assisted-by` footer. - [x] A human maintainer has personally reviewed and understood all AI-assisted content and accepts responsibility for it.
1 parent 60c3e99 commit f07a319

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,13 +78,16 @@ jobs:
7878
with:
7979
allowed-skips: >-
8080
${{
81-
!fromJSON(needs.change-detection.outputs.run-tests)
81+
(github.event.action == 'closed'
82+
|| !fromJSON(needs.change-detection.outputs.run-tests))
8283
&& 'tests,' || ''
8384
}} ${{
84-
!fromJSON(needs.change-detection.outputs.run-linter)
85+
(github.event.action == 'closed'
86+
|| !fromJSON(needs.change-detection.outputs.run-linter))
8587
&& 'linter,' || ''
8688
}} ${{
87-
!fromJSON(needs.change-detection.outputs.run-template)
89+
(github.event.action == 'closed'
90+
|| !fromJSON(needs.change-detection.outputs.run-template))
8891
&& 'template,' || ''
8992
}} ${{
9093
!fromJSON(needs.change-detection.outputs.run-docs)

0 commit comments

Comments
 (0)