[trace-view] Fixed a problem with reference lifetimes #24196
Merged
+987
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awelc
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
awelc
commented
Nov 6, 2025
| root_value_read: JSONTraceValue; | ||
| } | ||
|
|
||
| interface JSONTracePushEffect { |
Contributor
Author
There was a problem hiding this comment.
These were actually not necessary as they are subsumed by JSONTraceValue interface
awelc
commented
Nov 6, 2025
| frame_id: number; | ||
| gas_left: number; | ||
| return_: JSONTraceRuntimeValueContent[]; | ||
| return_: JSONTraceValue[]; |
Contributor
Author
There was a problem hiding this comment.
Unrelated fix (spotted when looking at trace format code...)
awelc
commented
Nov 6, 2025
| // Read as Buffer then view it as a Uint8Array for fzstd which expects Uint8Array | ||
| const buf = fs.readFileSync(traceFilePath); | ||
| const decompressed = await decompress(buf); | ||
| const u8 = new Uint8Array(buf.buffer, buf.byteOffset, buf.byteLength); |
Contributor
Author
There was a problem hiding this comment.
Another unrelated fix (for some reason the code was actually working even though TS compiler didn't like the types - now compilation is clean again)
awelc
commented
Nov 6, 2025
Contributor
Author
awelc
left a comment
awelc
left a comment
There was a problem hiding this comment.
Left some additional comments
dariorussi
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a fix to local variable lifetime approximation algorithm which was causing an exception being thrown when variable containing the actual value (that was referenced in the subsequent frames by another variable) went out of scope due to it's lifetime ending. Lifetimes should be extended by additional events in the trace beyond reads and writes.
Additionally, extended debug printing to catch these types of errors in the unit tests rather than when actually debugging code...
Test plan
Added a new test that was failing under old implementation but passes under the new one. All tests must pass