Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coupled model errors including rof month_annual_flow.ipynb has empty slice error #140

Open
TeaganKing opened this issue Oct 2, 2024 · 2 comments
Labels
bug Something isn't working lnd

Comments

@TeaganKing
Copy link
Collaborator

Describe the bug
In the rof month_annual_flow.ipynb, there is an empty slice error resulting from "inconsistent observation data length across the sites (some sites provide the data for a short period). No observed flow data is available depending analysis (or simulation) periods." (@nmizukami)

To Reproduce
Run the month_annual_flow.ipynb in the coupled models example.

Expected behavior
It'd be great to resolve this error with some if statements that could adjust the expected time period over which the calculation is done.

Additional context
Naoki was planning to adjust this in another PR.

@TeaganKing TeaganKing added bug Something isn't working lnd labels Oct 2, 2024
@TeaganKing
Copy link
Collaborator Author

Some additional coupled model errors include:

  • a register_cmap issue in ocean_surface.ipynb
  • an adf_diag import error in adf quick run

@TeaganKing TeaganKing changed the title rof month_annual_flow.ipynb has empty slice error coupled model errors including rof month_annual_flow.ipynb has empty slice error Jan 17, 2025
@mnlevy1981
Copy link
Collaborator

  • an adf_diag import error in adf quick run

I would support removing adf_quick_run.ipynb example now that we have link_to_ADF.ipynb working; I'm not terribly surprised the notebook fails, since we've updated ADF and moved stuff around recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lnd
Projects
None yet
Development

No branches or pull requests

2 participants