-
Notifications
You must be signed in to change notification settings - Fork 171
Closed
Labels
DiscussionRequires team discussionRequires team discussionmpasModel for Prediction Across Scales (MPAS)Model for Prediction Across Scales (MPAS)sciencescience decision needed to proceedscience decision needed to proceed
Description
I was reviewing a pull request and noticed that the mpas_atm/model_mod.f90:model_interpolate() routine uses the skintemp variable that is read from the mpas 'shapefile' (the file specified by init_template_filename in the namelist). Ditto for seaice. That doesn't seem right to me. I would have guessed those variables are not the same for all ensemble members. Maybe seaice could be constant - if the same ocean file was used for the forcing of all ensemble members.
seaice and skintemp are read in the get_grid() routine, rather than as part of the extended state.
call compute_surface_data_with_barycentric(skintemp(:), location, expected_obs(1), istatus(1))
seaice is used in the get_surftype routine.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
DiscussionRequires team discussionRequires team discussionmpasModel for Prediction Across Scales (MPAS)Model for Prediction Across Scales (MPAS)sciencescience decision needed to proceedscience decision needed to proceed