Non-trivial compiler warnings flagged in UFS debug mode

[NickSzapiro-NOAA]

Description

Compiler warnings in UFS flag:

.../ufs-weather-model/FV3/ccpp/physics/physics/GWD/cires_ugwpv1_triggers.F90(301): warning #6717: This name has not been given an explicit type.   [TLIM_FGF]
          if (dtot >= tlim_fgf ) kex = kex+1

tlim_fgf is defined above this in get_spectra_tau_nstgw but not in get_spectra_tau_okw.

Maybe this line should have tlim_okw instead

Steps to Reproduce

I've added -Wall -Wextra in compling but not sure if those are needed to see this

Additional Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

• Machine: hercules
• Compiler: intel debug

Output

[NickSzapiro-NOAA]

Another I think needs fixing:

.../ufs-weather-model/FV3/ccpp/physics/physics/GWD/cires_ugwpv1_oro.F90(14): warning #6843: A dummy argument with an explicit INTENT(OUT) declaration is not given an explicit value.   [ZLWB]
                      zobl, zlwb, zogw, tau_ogw, dudt_ogw, dvdt_ogw,      &

as it seems like zlwb is used in unified_ugwp_post.F90

[NickSzapiro-NOAA]

Hi @grantfirl. I updated the issue here and wonder if I could check-in on (1) if these seem worth following up on and (2) coordinating testing if so