-
Notifications
You must be signed in to change notification settings - Fork 5
Open
Description
Issue description
ESTIMATE TBD
The options element in the focus-trap.ts constructor below should either be:
- a parameter not named
optionsas it is a single option, and it should be a default parameter.public constructor(element: HTMLElement, focusableElements: string = 'button, [href], input, select, textarea, [tabindex]:not([tabindex="-1"])') { - Make
public constructor(element: HTMLElement, { focusableElements = 'button, [href], input, select, textarea, [tabindex]:not([tabindex="-1"])'}) {
Code:
public constructor(element: HTMLElement, options?: string) {
this.element = element;
this.focusableElements =
options ||
"button, [href], input, select, textarea, [tabindex]:not([tabindex='-1'])";
}
Metadata
Metadata
Assignees
Labels
No labels