[ndr-297] rename of dev_github_actions

Author: tim-knight-nhs

base_iam/iam_github_dev.tf

@@ -1,8 +1,8 @@
-# aws_iam_role.github_role_dev[0]:
-resource "aws_iam_role" "github_role_dev" {
+# aws_iam_role.dev_github_actions[0]:
+resource "aws_iam_role" "dev_github_actions" {
   count                 = local.is_sandbox_or_dev ? 1 : 0
   name                  = "${terraform.workspace}-github-actions-role"
-  description           = "This role is to provide access for GitHub actions to the development environment. "
+  description           = "This role is to provide access for GitHub Actions to the ${terraform.workspace} environment. "
   force_detach_policies = false
   max_session_duration  = 3600
   name_prefix           = null
@@ -48,7 +48,7 @@ resource "aws_iam_role" "github_role_dev" {
 
 resource "aws_iam_role_policy" "cloudtrail_dev" {
   count = local.is_sandbox_or_dev ? 1 : 0
-  role  = aws_iam_role.github_role_dev[0].id
+  role  = aws_iam_role.dev_github_actions[0].id
   name  = "cloudtrail"
   policy = jsonencode(
     {
@@ -82,7 +82,7 @@ resource "aws_iam_role_policy" "cloudtrail_dev" {
 
 resource "aws_iam_role_policy" "cloudwatch_logs_policy_dev" {
   count = local.is_sandbox_or_dev ? 1 : 0
-  role  = aws_iam_role.github_role_dev[0].id
+  role  = aws_iam_role.dev_github_actions[0].id
   name  = "cloudwatch_logs_policy"
   policy = jsonencode(
     {
@@ -124,7 +124,7 @@ resource "aws_iam_role_policy" "cloudwatch_logs_policy_dev" {
 
 resource "aws_iam_role_policy" "ecs_policy_dev" {
   count = local.is_sandbox_or_dev ? 1 : 0
-  role  = aws_iam_role.github_role_dev[0].id
+  role  = aws_iam_role.dev_github_actions[0].id
   name  = "ecs_policy"
   policy = jsonencode(
     {
@@ -146,7 +146,7 @@ resource "aws_iam_role_policy" "ecs_policy_dev" {
 
 resource "aws_iam_role_policy" "github_actions_waf_override_dev" {
   count = local.is_sandbox_or_dev ? 1 : 0
-  role  = aws_iam_role.github_role_dev[0].id
+  role  = aws_iam_role.dev_github_actions[0].id
   name  = "github_actions_waf_override"
   policy = jsonencode(
     {
@@ -164,7 +164,7 @@ resource "aws_iam_role_policy" "github_actions_waf_override_dev" {
 
 resource "aws_iam_role_policy" "lambda_layer_policy_dev" {
   count = local.is_sandbox_or_dev ? 1 : 0
-  role  = aws_iam_role.github_role_dev[0].id
+  role  = aws_iam_role.dev_github_actions[0].id
   name  = "lambda_layer_policy"
   policy = jsonencode(
     {
@@ -192,7 +192,7 @@ resource "aws_iam_role_policy" "lambda_layer_policy_dev" {
 
 resource "aws_iam_role_policy" "rum_policy_dev" {
   count = local.is_sandbox_or_dev ? 1 : 0
-  role  = aws_iam_role.github_role_dev[0].id
+  role  = aws_iam_role.dev_github_actions[0].id
   name  = "rum_policy"
   policy = jsonencode(
     {
@@ -254,7 +254,7 @@ resource "aws_iam_role_policy" "rum_policy_dev" {
 
 resource "aws_iam_role_policy" "step_functions_dev" {
   count = local.is_sandbox_or_dev ? 1 : 0
-  role  = aws_iam_role.github_role_dev[0].id
+  role  = aws_iam_role.dev_github_actions[0].id
   name  = "step_functions"
   policy = jsonencode(
     {
@@ -280,7 +280,7 @@ resource "aws_iam_role_policy" "step_functions_dev" {
 
 resource "aws_iam_role_policy" "github_terraform_tagging_policy_dev" {
   count = local.is_sandbox_or_dev ? 1 : 0
-  role  = aws_iam_role.github_role_dev[0].id
+  role  = aws_iam_role.dev_github_actions[0].id
   name  = "github_terraform_tagging_policy"
   policy = jsonencode(
     {
@@ -389,13 +389,13 @@ resource "aws_iam_role_policy" "github_terraform_tagging_policy_dev" {
 
 resource "aws_iam_role_policy_attachment" "ReadOnlyAccess_dev" {
   count      = local.is_sandbox_or_dev ? 1 : 0
-  role       = aws_iam_role.github_role_dev[0].name
+  role       = aws_iam_role.dev_github_actions[0].name
   policy_arn = "arn:aws:iam::aws:policy/ReadOnlyAccess"
 }
 
 resource "aws_iam_role_policy_attachment" "github_actions_terraform_full_dev" {
   count      = local.is_sandbox_or_dev ? 1 : 0
-  role       = aws_iam_role.github_role_dev[0].name
+  role       = aws_iam_role.dev_github_actions[0].name
   policy_arn = aws_iam_policy.github_actions_terraform_full_dev[0].arn
 }
 
@@ -657,7 +657,7 @@ resource "aws_iam_policy" "github_actions_terraform_full_dev" {
 
 resource "aws_iam_role_policy_attachment" "github_actions_extended_dev" {
   count      = local.is_sandbox_or_dev ? 1 : 0
-  role       = aws_iam_role.github_role_dev[0].name
+  role       = aws_iam_role.dev_github_actions[0].name
   policy_arn = aws_iam_policy.github_actions_extended_dev[0].arn
 }
 

base_iam/terraform.tf

@@ -3,7 +3,7 @@ terraform {
   required_providers {
     aws = {
       source  = "hashicorp/aws"
-      version = "~> 5.0"
+      version = "~> 6.0"
     }
   }
 

base_iam/variables.tf

@@ -23,12 +23,10 @@ variable "aws_account_id" {
 locals {
   is_sandbox    = !contains(["ndr-dev", "ndr-test", "pre-prod", "prod"], terraform.workspace)
   is_production = contains(["pre-prod", "prod"], terraform.workspace)
-
   is_sandbox_or_dev = !contains(["ndr-test", "pre-prod", "prod"], terraform.workspace)
   is_development    = terraform.workspace == "ndr-dev"
   is_testing        = terraform.workspace == "ndr-test"
   is_pre_production = terraform.workspace == "pre-prod"
   is_prod           = terraform.workspace == "prod"
-
   shared_terraform_state_bucket = "ndr-${var.environment}-terraform-state-${data.aws_caller_identity.current.account_id}"
 }