From 0d328e95941a933201dc00fad37b7e556fb18f65 Mon Sep 17 00:00:00 2001 From: Ximon Eighteen <3304436+ximon18@users.noreply.github.com> Date: Wed, 10 Sep 2025 22:53:17 +0200 Subject: [PATCH 1/2] FIX: XfrMiddlewareService should always support at least one concurrent XFR. --- src/net/server/middleware/xfr/service.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/net/server/middleware/xfr/service.rs b/src/net/server/middleware/xfr/service.rs index 8f330eaba..83a8f262a 100644 --- a/src/net/server/middleware/xfr/service.rs +++ b/src/net/server/middleware/xfr/service.rs @@ -111,6 +111,9 @@ where xfr_data_provider: XDP, max_concurrency: usize, ) -> Self { + let max_concurrency = (max_concurrency > 0) + .then_some(max_concurrency) + .unwrap_or(1); let zone_walking_semaphore = Arc::new(Semaphore::new(max_concurrency)); let batcher_semaphore = Arc::new(Semaphore::new(max_concurrency)); From 45045795fa198f63acea0aff584e6aa14d319131 Mon Sep 17 00:00:00 2001 From: Ximon Eighteen <3304436+ximon18@users.noreply.github.com> Date: Mon, 24 Nov 2025 22:24:39 +0100 Subject: [PATCH 2/2] Clippy. --- src/net/server/middleware/xfr/service.rs | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/net/server/middleware/xfr/service.rs b/src/net/server/middleware/xfr/service.rs index 83a8f262a..cb4f33f51 100644 --- a/src/net/server/middleware/xfr/service.rs +++ b/src/net/server/middleware/xfr/service.rs @@ -111,9 +111,11 @@ where xfr_data_provider: XDP, max_concurrency: usize, ) -> Self { - let max_concurrency = (max_concurrency > 0) - .then_some(max_concurrency) - .unwrap_or(1); + let max_concurrency = if max_concurrency > 0 { + max_concurrency + } else { + 1 + }; let zone_walking_semaphore = Arc::new(Semaphore::new(max_concurrency)); let batcher_semaphore = Arc::new(Semaphore::new(max_concurrency));