update decision state for OnVariable and ActivePowerVariable #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change seems to give the desired behavior of the generator outage and then being brought back online: |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -368,9 +355,11 @@ function update_decision_state!( | |||
| simulation_time::Dates.DateTime, | |||
| model_params::ModelStoreParams, | |||
| ) where {T <: VariableType, U <: PSY.Component} | |||
| event_ocurrence_data = get_decision_state_data(state, AvailableStatusParameter(), U) | |||
| @error "UPDATE DECISION STATE $key" | |||
| event_ocurrence_data = get_decision_state_data(state, AvailableStatusChangeParameter(), U) | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| event_ocurrence_data = get_decision_state_data(state, AvailableStatusChangeParameter(), U) | |
| event_ocurrence_data = | |
| get_decision_state_data(state, AvailableStatusChangeParameter(), U) |
Comment on lines
+384
to
+385
| if event_status_data.values[name, outage_index] == 0.0 | ||
| state_data.values[name, outage_index] = 0.0 |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| if event_status_data.values[name, outage_index] == 0.0 | |
| state_data.values[name, outage_index] = 0.0 | |
| if event_status_data.values[name, outage_index] == 0.0 | |
| state_data.values[name, outage_index] = 0.0 |
| if event_status_data.values[name, outage_index] == 0.0 | ||
| state_data.values[name, outage_index] = 0.0 | ||
| @info "forcing $key to zero at index $outage_index because status was zero for $name" | ||
| else |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| else | |
| else |
Comment on lines
+389
to
+390
| end | ||
| if outage_index == length(state_data.values[name, :]) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| end | |
| if outage_index == length(state_data.values[name, :]) | |
| end | |
| if outage_index == length(state_data.values[name, :]) |
Comment on lines
+392
to
+394
| end | ||
| outage_index += 1 | ||
| end |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| end | |
| outage_index += 1 | |
| end | |
| end | |
| outage_index += 1 | |
| end |
|
When applying the event, if the status is zero moving forward from a status change, then the OnVariable and ActivePower should be forced to zero in the decision model as well? |
jd-lara
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.