Skip to content

TensorRT-8.0 Support #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kinglintianxia opened this issue Jul 15, 2021 · 6 comments
Closed

TensorRT-8.0 Support #593

kinglintianxia opened this issue Jul 15, 2021 · 6 comments

Comments

@kinglintianxia
Copy link

kinglintianxia commented Jul 15, 2021

TensorRT-8.0 changed the api, do you conside support it? @saulzar @vellamike

@SrivastavaKshitij
Copy link
Contributor

what changed exactly ? I havent looked at the documentation yet.

@kinglintianxia
Copy link
Author

what changed exactly ? I havent looked at the documentation yet.

  • TensorRT OSS v8.0.1 removed TensorRT 6.0's IPlugin and IPluginFactory interfaces, the changes of API leads to build error!
  • Another question by the way, does the interpolate plugin fix the Pytorch -> TensorRT-7.0 problem which was rehauled by TensorRt-8.0?
    Thanks!

@jaybdub
Copy link
Contributor

jaybdub commented Jul 19, 2021

Thanks for reaching out!

Regarding TensorRT 8.0 support.

There are a couple open PRs from community developers for supporting TensorRT 8.0

#581

#560

I have not yet verified these, but hope to do so soon.

Please let me know if these help for your use case, or you run into any issues.

Best,
John

@kinglintianxia
Copy link
Author

Thanks for reaching out!

Regarding TensorRT 8.0 support.

There are a couple open PRs from community developers for supporting TensorRT 8.0

#581

#560

I have not yet verified these, but hope to do so soon.

Please let me know if these help for your use case, or you run into any issues.

Best,
John

Thanks for your reply!
I'm using Jetson Xavier Nx(L4T R32.5.1, TensorRT-7.1.3) and encount the interpolate transition problem, can I fix it through cerrect the interpolate plugin or the only thing I can do is just waiting for the next release of Jetpack(with TensorRT-8.0)?
Thanks!

@jaybdub
Copy link
Contributor

jaybdub commented Jul 27, 2021

Hi @kinglintianxia ,

I've started the following PR for integrating TensorRT 8.0 and addressing the issues that arise.

#599

One issue that was addressed was an API change for the interpolate layers when align_corners=True.

That said, both TensorRT 7.1, and 8.0 shouldn't rely on the interpolate plugin, but instead use the native TensorRT layers.

Please let me know if this helps or you have any questions.

Best,
John

@kinglintianxia
Copy link
Author

@jaybdub
Thanks for your reply!
I have solved the interpolate transition problem by using torch.nn.functional.interpolate(align_corner=True, size) mode instead of torch.nn.functional.interpolate(align_corner=True, scale_factor)mode, this leeds to correct transition path.
Thanks again for your job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants