[codex] docs: clarify deduplication input discovery#2130
Conversation
Signed-off-by: Lawrence Lane <llane@nvidia.com>
Greptile SummaryThis PR clarifies how the exact, fuzzy, semantic, and duplicate-removal deduplication workflows discover input files, and corrects stale parameter names (
Confidence Score: 5/5Documentation-only change; all renamed parameters and discovery behaviour were verified against the live Python source. Every parameter rename was confirmed correct against TextDuplicatesRemovalWorkflow and the recursive/top-level discovery semantics were confirmed against FilePartitioningStage. No executable code is modified. index.mdx — the abbreviated removal snippet in the ID Field Configuration accordion omits duplicate_id_field, which defaults to id rather than _curator_dedup_id; worth a second look before merge. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[input_file_extensions provided?] -->|None or empty list| B[Use defaults from input_filetype]
A -->|Non-empty list| C[Use provided extensions as-is]
B --> D{input_filetype}
D -->|parquet| E[Extension: .parquet]
D -->|jsonl| F[Extensions: .jsonl and .json]
E --> G[input_path type?]
F --> G
C --> G
G -->|Single string path| H[Recursive discovery - all nested subdirectories]
G -->|List of paths| I[Top-level only per entry - non-recursive]
H --> J[Filter files by extension]
I --> J
J --> K[input_filetype selects reader - not extensions]
K --> L[Read files with parquet or jsonl reader]
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[input_file_extensions provided?] -->|None or empty list| B[Use defaults from input_filetype]
A -->|Non-empty list| C[Use provided extensions as-is]
B --> D{input_filetype}
D -->|parquet| E[Extension: .parquet]
D -->|jsonl| F[Extensions: .jsonl and .json]
E --> G[input_path type?]
F --> G
C --> G
G -->|Single string path| H[Recursive discovery - all nested subdirectories]
G -->|List of paths| I[Top-level only per entry - non-recursive]
H --> J[Filter files by extension]
I --> J
J --> K[input_filetype selects reader - not extensions]
K --> L[Read files with parquet or jsonl reader]
Reviews (5): Last reviewed commit: "Merge branch 'main' into codex/docs-dedu..." | Re-trigger Greptile |
Signed-off-by: Lawrence Lane <llane@nvidia.com>
|
🌿 Preview your docs: https://nvidia-preview-codex-docs-dedup-input-defaults.docs.buildwithfern.com/nemo/curator Here are the markdown pages you've updated: |
|
/ok to test d9406a8 |
What changed
None, empty-list, and explicit extension override behaviorWhy
PR #2045 changed deduplication workflows to derive
input_file_extensionsfrominput_filetype, but the published Fern pages did not describe the defaults or override semantics. Users could also copy removal examples that referenced constructor arguments no longer present inTextDuplicatesRemovalWorkflow.User impact
Users can now predict which files each workflow discovers, safely use custom suffixes such as
.pq, and preserve generated-ID consistency between identification and removal.Validation
npm run checkfromfern/: 0 errorsfern docs broken-links: no errors in changed pages; 22 existing errors remain in older API-reference pagesgit diff --checkCloses #2127
Parent tracking issue: #2118