Skip to content

@run.cli.entrypoint(skip_confirmation=True) has no effect — confirmation prompt still shown #608

Description

@ManoharPaturi

Description

The documented skip_confirmation parameter of @run.cli.entrypoint ("If True, skips user confirmation before execution") is stored on the Entrypoint object but never consumed when the CLI command is built. Every non-dryrun invocation still prompts Continue? [y/N] unless the user additionally passes --yes/-y or run.skip_confirmation=True.

Steps to reproduce

# app.py
import nemo_run as run

@run.cli.entrypoint(skip_confirmation=True)
def hello(name: str = "world"):
    print(f"hello {name}")

if __name__ == "__main__":
    run.cli.main(hello)
$ python app.py name=test
...
Continue? [y/N]:

Expected behavior

With skip_confirmation=True on the entrypoint the command runs without prompting (same as --yes).

Actual behavior

The prompt still appears. Entrypoint.skip_confirmation is dead — _add_executor_command never forwards it to RunContext.cli_command, so the generated command's skip_confirmation option keeps its False default.

Fwiw the repo's own tests work around this: test/cli/test_api.py declares entrypoints with skip_confirmation=True yet passes run.skip_confirmation=True / --yes when invoking them.

Environment

nemo-run main (b85eb67), Python 3.12, macOS

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions