Skip to content

Commit 2a2de57

Browse files
binaryaaronclaude
andcommitted
docs: address PR review comments
- Clear outputs from differential-privacy.ipynb tutorial notebook - Move Python 3.11 syntax-compatibility note from README to CONTRIBUTING - Fix cu128 -> cu129 extras mismatch in docker.md comparison table - Align getting-started prerequisite line with markdown style rules Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Aaron Gonzales <aagonzales@nvidia.com>
1 parent 6034d6e commit 2a2de57

5 files changed

Lines changed: 266 additions & 79547 deletions

File tree

CONTRIBUTING.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -544,6 +544,10 @@ Before submitting a PR:
544544

545545
For detailed style guidelines covering Python, markdown, Dockerfiles, shell scripts, testing, and docstrings, see [STYLE_GUIDE.md](STYLE_GUIDE.md).
546546

547+
### Python Version Compatibility
548+
549+
Although the default development/runtime interpreter is Python 3.13, source code must remain Python 3.11 syntax-compatible until the NMP platform moves its base Python version to 3.12. Do not use Python 3.12-only syntax such as PEP 695 `type` statements or bracketed generic class/function parameters in shared package code yet.
550+
547551
### Formatting, Linting, and Type Checking
548552

549553
Use `make` targets instead of running `ruff` or `ty` directly. The targets use pinned tool versions from `.mise.[toml|lock]` (installed via `make setup`) and check all tracked files.

README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@ Read detailed usage below, or jump to the documentation with [Getting Started](h
1414
- NVIDIA GPU (A100 or larger) for training and generation
1515
- Linux only -- macOS, Windows, and Apple Silicon are not supported for training or generation. A CPU-only install is available for development and configuration validation.
1616

17-
> Contributor note: although the default development/runtime interpreter is Python 3.13, source code must remain Python 3.11 syntax-compatible until the NMP platform moves its base Python version to 3.12. Do not use Python 3.12-only syntax such as PEP 695 `type` statements or bracketed generic class/function parameters in shared package code yet.
18-
1917
### Installation
2018

2119
```bash

docs/developer-guide/docker.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ To reduce size:
263263
| Aspect | `Dockerfile.cuda` | `Dockerfile.test_ci` |
264264
|--------|-------------------|----------------------|
265265
| Base | `nvidia/cuda:12.9.1-runtime-ubuntu22.04` | `python:3.13-slim` |
266-
| Extras | `cu128` + `engine` | `cpu` + `engine` |
266+
| Extras | `cu129` + `engine` | `cpu` + `engine` |
267267
| GPU | Required | Not needed |
268268
| Stages | `tools` / `deps` / `runtime` / `dev` | `setup` / `install-deps` |
269269
| Use case | Training, generation, evaluation | CPU-only unit tests and CI checks |

0 commit comments

Comments
 (0)