Skip to content

Commit e9748f3

Browse files
committed
refactor(projects): migrate projects consumers to typed ProjectsClient
Migrate projects API call sites from sdk.projects.* (Stainless SDK) to client_from_platform(sdk, ProjectsClient).* (typed HTTP client), following the pattern established in #1277. AIRCORE-827 Signed-off-by: Max Dubrinsky <mdubrinsky@nvidia.com>
1 parent 03c0d23 commit e9748f3

2 files changed

Lines changed: 16 additions & 6 deletions

File tree

e2e/test_entities.py

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@
2121

2222
import pytest
2323
from nemo_platform import APIStatusError, NeMoPlatform
24+
from nemo_platform_plugin.client.adapter import client_from_platform
25+
from nemo_platform_plugin.projects.client import ProjectsClient
26+
from nemo_platform_plugin.projects.types import CreateProjectRequest
2427
from nmp.testing import as_service_for
2528

2629
ENTITY_TYPE = "e2e-test-entity"
@@ -143,10 +146,13 @@ def test_entity_with_project(sdk: NeMoPlatform, entity_store_sdk: NeMoPlatform,
143146
entity_name = _unique_name()
144147

145148
# Create project first
146-
project = sdk.projects.create(
147-
workspace=workspace,
148-
name=project_name,
149-
description="E2E test project",
149+
project = (
150+
client_from_platform(sdk, ProjectsClient)
151+
.create_project(
152+
workspace=workspace,
153+
body=CreateProjectRequest(name=project_name, description="E2E test project"),
154+
)
155+
.data()
150156
)
151157
assert project.name == project_name
152158

@@ -179,7 +185,7 @@ def test_entity_with_project(sdk: NeMoPlatform, entity_store_sdk: NeMoPlatform,
179185

180186
finally:
181187
# Clean up project
182-
sdk.projects.delete(name=project_name, workspace=workspace)
188+
client_from_platform(sdk, ProjectsClient).delete_project(name=project_name, workspace=workspace)
183189

184190

185191
def test_entity_without_project(entity_store_sdk: NeMoPlatform, workspace: str):

packages/nmp_testing/src/nmp/testing/client.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -646,9 +646,13 @@ async def _run() -> None:
646646
sdk.workspaces.create(name=ws_id)
647647
except ConflictError:
648648
logger.warning(f"Workspace '{ws_id}' already exists (created by service startup)")
649+
from nemo_platform_plugin.projects.client import ProjectsClient
650+
from nemo_platform_plugin.projects.types import CreateProjectRequest
651+
652+
projects_client = client_from_platform(sdk, ProjectsClient)
649653
for ws_id, proj_name in parsed_projects:
650654
try:
651-
sdk.projects.create(workspace=ws_id, name=proj_name)
655+
projects_client.create_project(workspace=ws_id, body=CreateProjectRequest(name=proj_name))
652656
except ConflictError:
653657
logger.warning(f"Project '{proj_name}' in workspace '{ws_id}' already exists")
654658

0 commit comments

Comments
 (0)